Add MIME Checks for link rel=manifest #24446
Conversation
wpt-pr-bot
requested review from
annevk,
domenic,
foolip,
jdm,
jgraham,
zcorpan and
zqzhang
html/links/manifest/mime-type-application-manifest+json.headers
Outdated
Show resolved
Hide resolved
| <h1>Test JSON MIME Type support for web manifest</h1> | ||
| <p> | ||
| To pass, the use agent must treat the manifest valid (name is "pass"). The | ||
| response's Content-Type metadata is a JSON MIME type "text/json". |
There was a problem hiding this comment.
Do we want to test an "invalid" media type?
There was a problem hiding this comment.
Good idea... will add an actual invalid type.
|
@marcoscaceres the checks for this PR will be blocked due to the Taskcluster Checks migration. You can either rebase/merge-from-master the PR to bring in the new Taskcluster config, or just let me know when you want it merged and I can admin-merge it for you :) |
|
Thanks @stephenmcgruer! I'll rebase. |
marcoscaceres
force-pushed
the
manifest_html
branch
from
5f311e6 to
b895983
Compare
|
The lint is failing because html/links/manifest/mime-type-none.html and html/links/manifest/mime-type-invalid.html are being interpreted as (misnamed) visual tests. To avoid this, one can put them in a resources/ or support/ subdirectory. |
|
Thanks for the tip, @foolip! Fixed the naming... they should have been "-manual.html" - so thankfully the linter caught those! |
Part of #24389