Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass WPT for Web App Manifest #23816

Conversation

aarongustafson
Copy link
Contributor

@marcoscaceres Did I do this right?

Related: w3c/manifest#826

@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

Copy link
Contributor

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! 🥇

manifest/idlharness.window.js Outdated Show resolved Hide resolved
manifest/Manifest.html Outdated Show resolved Hide resolved
manifest/Manifest.html Outdated Show resolved Hide resolved
Co-authored-by: Marcos Cáceres <[email protected]>
Copy link
Contributor

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We concluded to drop the .https. from the filename.

@marcoscaceres marcoscaceres merged commit fd60ba2 into web-platform-tests:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants