[WeakRefs] Implement WeakRefs integration #19998
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 30, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1873754
branch
2 times, most recently
from
2346d5a to
3ec5dd8
Compare
This uses the V8 API to register a clean up task that will execute some time later at idle time. The JavaScript spec is defined here: https://tc39.es/proposal-weakrefs/ The HTML integration is defined here: whatwg/html#4571 (Note that this CL doesn't implement ClearKeptObjects part of the spec yet, a follow on CL will do that.) TODO (before sumbitting this CL): - Add tests Bug: 1016767 Change-Id: I2db82dc9d037d1e3bc0ec8c192d5b06908161adc
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1873754
branch
from
3ec5dd8 to
0e5ddd5
Compare
|
Close this PR because the Chromium CL cannot be found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the V8 API to register a clean up task that will execute
some time later at idle time.
The JavaScript spec is defined here:
https://tc39.es/proposal-weakrefs/
The HTML integration is defined here:
whatwg/html#4571
(Note that this CL doesn't implement ClearKeptObjects part of the
spec yet, a follow on CL will do that.)
TODO (before sumbitting this CL):
Bug: 1016767
Change-Id: I2db82dc9d037d1e3bc0ec8c192d5b06908161adc
Reviewed-on: https://chromium-review.googlesource.com/1873754
WPT-Export-Revision: 905ae5e21d28f9fe8f184a0f4cc6617669f952f1