Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #12696: make property_order default to empty list #15111

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Fix #12696: make property_order default to empty list #15111

merged 1 commit into from
Apr 11, 2019

Conversation

gsnedders
Copy link
Member

IIRC, @jgraham didn't like this, but I can't find where he said why.

Fixes #12696.

@gsnedders gsnedders requested a review from jgraham January 28, 2019 15:22
@wpt-pr-bot wpt-pr-bot added infra wptrunner The automated test runner, commonly called through ./wpt run labels Jan 28, 2019
@gsnedders
Copy link
Member Author

@jgraham ping

@gsnedders gsnedders closed this Feb 20, 2019
@gsnedders gsnedders reopened this Feb 20, 2019
@gsnedders gsnedders merged commit 9fb1329 into web-platform-tests:master Apr 11, 2019
@gsnedders gsnedders deleted the workaround-property-order-None branch April 11, 2019 14:20
marcoscaceres pushed a commit that referenced this pull request Jul 23, 2019
@gsnedders
Fix #12696: make property_order default to empty list (#15111)
a59b02a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ms2ger Ms2ger Ms2ger approved these changes

@jgraham jgraham Awaiting requested review from jgraham

@jugglinmike jugglinmike Awaiting requested review from jugglinmike

Assignees

@jugglinmike jugglinmike

Labels
infra wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gsnedders @Ms2ger @jugglinmike @wpt-pr-bot