Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Web Locks uniqueName helper (likely) globally unique #15018

Closed
wants to merge 1 commit into from
Closed

Make the Web Locks uniqueName helper (likely) globally unique #15018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions web-locks/resources/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
// Generate a unique resource identifier, using the script path and
// test case name. This is useful to avoid lock interference between
// test cases.
let res_num = 0;
self.uniqueName = (testCase, prefix) => {
return `${self.location.pathname}-${prefix}-${testCase.name}-${++res_num}`;
const rand = Math.floor(1e10 * Math.random());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it helps, I've used this in some personal projects -- Math.random().toString(36).substr(2)

return `${self.location.pathname}-${prefix}-${testCase.name}-${rand}`;
};

// Inject an iframe showing the given url into the page, and resolve
Expand Down