Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding: align encodeInto() test with reality #14775

Merged
merged 3 commits into from
Jan 10, 2019
Merged

Encoding: align encodeInto() test with reality #14775

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1c0a1d
Encoding: align encodeInto() test with reality
annevk Jan 9, 2019
5cdb5b7
make it work in workers
annevk Jan 10, 2019
e1dc869
typos
annevk Jan 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions encoding/encodeInto.any.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,5 +140,10 @@ test(() => {
assert_equals(read, 0);
assert_equals(written, 0);
self.postMessage(buffer, "/", [buffer]);
assert_throws(new TypeError(), () => new TextEncoder().encodeInto("", view));
}, "encodeInto() cannot operate on a detached buffer");
const { read2, written2 } = new TextEncoder().encodeInto("", view);
assert_equals(read2, 0);
assert_equalss(written2, 0);
annevk marked this conversation as resolved.
Show resolved Hide resolved
const { read3, written3 } = new TextEncoder().encodeInto("test", view);
assert_equals(read3, 0);
assert_equalss(written3, 0);
annevk marked this conversation as resolved.
Show resolved Hide resolved
}, "encodeInto() and a detached output buffer");