Switch WebKit browser product to WebDriver executors #13339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch away from Selenium executors to WebDriverTestharnessExecutor and WebDriverRefTestExecutor for the WebKit browser product. For the moment this requires manually mapping Selenium-style capability names to the W3C equivalents that can be handled by WebKit's WebDriver implementation. The browserVersion value is also hard-coded to the 2.20 release series for the GTK+ port of WebKit as that's when the WebDriver functionality was introduced.
wpt-pr-bot
added
infra
wptrunner
|
What testing have you done of this? Have you run at least |
jgraham
requested changes
Oct 3, 2018
| @@ -43,6 +43,16 @@ def capabilities_for_port(server_config, **kwargs): | |||
| "certificateFile": kwargs["host_cert_path"]} | |||
| ] | |||
| } | |||
|
|
|||
| # Manually map Selenium's key names to the corresponding W3C versions. | |||
There was a problem hiding this comment.
Couldn't you just statically define a set of capabilities rather than still depending on the selenium defaults? Looks like the DesiredCapabilites.WEBKITGTK capabilities are rather simple anyway.
There was a problem hiding this comment.
Yeah I'll do that.
|
A small set of tests is run currently. Nothing changes there. Things in Now: |
jgraham
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch away from Selenium executors to WebDriverTestharnessExecutor and
WebDriverRefTestExecutor for the WebKit browser product.
For the moment this requires manually mapping Selenium-style capability names
to the W3C equivalents that can be handled by WebKit's WebDriver implementation.
The browserVersion value is also hard-coded to the 2.20 release series for the
GTK+ port of WebKit as that's when the WebDriver functionality was introduced.