Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging generated clipboard API tests #1242

Open
wants to merge 42 commits into
base: master
Choose a base branch
from
Open

Merging generated clipboard API tests #1242

wants to merge 42 commits into from

Conversation

hallvors
Copy link
Contributor

@hallvors hallvors commented Sep 13, 2014 •
edited by wpt-pr-bot
Loading

These tests are generated from script elements inside spec source code using the Python script here:
http://dev.w3.org/2006/webapi/clipops/TC-generator/

@AFBarstow
Copy link
Contributor

@hallvors awesome :-)!

@sideshowbarker
Copy link
Contributor

See https://travis-ci.org/w3c/web-platform-tests/builds/43112700
The pathnames of three of the files that were renamed now exceed 150 chars:

$ python tools/scripts/lint.py
PATH LENGTH: /clipboard-apis/clipboardevent_interface_events_triggered_from_documentexeccommand_inside_trusted_events_do_affect_system_clipboard_copy_on_document.html longer than maximum path length (153 > 150)
PATH LENGTH: /clipboard-apis/clipboardevent_interface_events_triggered_from_documentexeccommand_inside_trusted_events_do_affect_system_clipboard_cut_on_document.html longer than maximum path length (152 > 150)
PATH LENGTH: /clipboard-apis/types_property_all_implementations_must_return_textplain_as_one_of_the_types_entries_when_there_is_plain_text_on_the_clipboard_paste_on_document.html longer than maximum path length (165 > 150)
There were 3 errors (PATH LENGTH: 3)

@hallvors hallvors mentioned this pull request Jul 22, 2015
Closed
@hallvors
Copy link
Contributor Author

One major issue I know about: all setTimeout() usage should be fixed to use testharness.js conventions.

Apart from that, further review is welcome :)

@hallvors hallvors force-pushed the hallvors/clipboard-api-2 branch from deaf7d1 to 1301bbf Compare July 27, 2015 12:38
Hallvord R. M. Steen added 19 commits July 27, 2015 17:26
adding clipboard API tests
4a00c77
adding helper files
f6d5c93
Added script that extracts tests from spec source code and generates …
21cd455 
…various variants
mostly minor fixes
9ee689a
giving test files more meaningful names, avoid numbers that change ev…
b00e6a1 
…ery time the test suite is built
changed test order in testlist.rb
cd31aef
renaming some test because file names were too long, adding some new
ec7637c
Whitespace fixes and other stuff to make Travis happy
c9465e8
and a few more whitespace fixes in helper files
cad1fb7
dropping Ruby file listing test cases and code to generate it - legac…
0dda6bc 
…y stuff
integrating test setup with testharness.js, addresses https://critic.…
6f7981d 
…hoppipolla.co.uk/showcomment?chain=12228
small fixes for better testharness.js integration
3e0994b
removed two tests expecting execCommand(paste) to work
ec27e08
various testharness.js integration fixes and test errata
fa24da7
Remove pointless whitespace in front of test titles
a6f7313
removing clipboard event constructor config that is not being tested
0912abc
spec changed event object construction, tests need fixing
19df515
adding clipboard API tests
d5eeb16
mostly minor fixes
b009493
@hallvors hallvors force-pushed the hallvors/clipboard-api-2 branch from 68be7a9 to ff638f9 Compare July 27, 2015 16:02
@ayg ayg closed this Aug 28, 2016
@ayg ayg deleted the hallvors/clipboard-api-2 branch August 28, 2016 13:58
@gsnedders gsnedders restored the hallvors/clipboard-api-2 branch August 28, 2016 20:17
@gsnedders gsnedders reopened this Aug 28, 2016
@ayg ayg closed this Oct 26, 2016
@ayg ayg deleted the hallvors/clipboard-api-2 branch October 26, 2016 17:38
@ayg ayg restored the hallvors/clipboard-api-2 branch October 26, 2016 18:04
@ayg ayg reopened this Oct 26, 2016
@annevk annevk mentioned this pull request Mar 16, 2017
Open
@garykac
Copy link
Member

garykac commented May 1, 2017

@gked This PR is possibly of interest to you since you were looking into migrating clipboard tests into WPT.

@foolip
Copy link
Member

foolip commented Jun 12, 2018

I found this PR linked in https://github.com/w3c/clipboard-apis/blob/18e871aba0be2849c67ea8416f7bdf26de30562c/README.md. What is the status of this, anyone planning to finish it?

@wpt-pr-bot wpt-pr-bot requested a review from garykac June 12, 2018 09:36
@gsnedders
Copy link
Member

Do we know if these were reviewed prior to landing in the clipboard API repo?

gsnedders
gsnedders requested changes Aug 31, 2018
View reviewed changes
Copy link
Member

@gsnedders gsnedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of major issues from a quick glance where tests are actually manual.

clipboard-apis/support/_lib.js
}
}
if(typeof triggerTestManually==='function'){
/* Tests that require user interaction define a "triggerTestManually()" function.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these tests need a -manual suffix.

clipboard-apis/cancelling_default_action_basic_test_copy_on_inputtext.html
(function(){
var t = async_test()
var dataToPaste="clipboard text" ;
var extPassCond="clipboard text" ;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything with an external pass condition can't be verified through JS and therefore needs to be -manual.

@gsnedders gsnedders closed this Jan 24, 2020
@gsnedders gsnedders deleted the hallvors/clipboard-api-2 branch January 24, 2020 18:06
@gsnedders gsnedders restored the hallvors/clipboard-api-2 branch January 24, 2020 18:40
@Hexcles Hexcles reopened this Jan 24, 2020
@ShahriarNasseri
Copy link

Could you delete w portable management.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsnedders gsnedders gsnedders requested changes

@garykac garykac Awaiting requested review from garykac

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
clipboard-apis wg-webapps wg-webplatform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.