Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make fetch_tests_from_worker return a promise #10978

Merged
merged 1 commit into from
May 14, 2018
Merged

Make fetch_tests_from_worker return a promise #10978

merged 1 commit into from
May 14, 2018

Conversation

jakearchibald
Copy link
Contributor

@jakearchibald jakearchibald commented May 14, 2018 •
edited by wpt-reviewable-bot
Loading

Extracted from #10348 (comment).

This change is Reviewable

@jakearchibald jakearchibald requested a review from Ms2ger May 14, 2018 02:06
@jakearchibald jakearchibald mentioned this pull request May 14, 2018
Merged
Ms2ger
Ms2ger approved these changes May 14, 2018
View reviewed changes
Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned on IRC, I'm not terribly excited, but let's go ahead anyway.

@Ms2ger Ms2ger merged commit fcb5082 into web-platform-tests:master May 14, 2018
@jakearchibald
Copy link
Contributor Author

jakearchibald commented May 14, 2018 via email

@Ms2ger
Copy link
Contributor

Ms2ger commented May 15, 2018

Sorry, I confused myself, the IRC conversation was about another change. All good here :)

@jakearchibald
Copy link
Contributor Author

Haha phew, I thought I'd finally lost my loose grip on reality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ms2ger Ms2ger Ms2ger approved these changes

@ayg ayg Awaiting requested review from ayg

@dontcallmedom dontcallmedom Awaiting requested review from dontcallmedom

@gsnedders gsnedders Awaiting requested review from gsnedders

@jgraham jgraham Awaiting requested review from jgraham

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker

Assignees
No one assigned
Labels
docs infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakearchibald @Ms2ger @wpt-pr-bot