Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selenium executor uses wrong viewport size for reftests #12578

Closed
gsnedders opened this issue Aug 20, 2018 · 2 comments · Fixed by #12695
Closed

Selenium executor uses wrong viewport size for reftests #12578

gsnedders opened this issue Aug 20, 2018 · 2 comments · Fixed by #12695
Labels
infra priority:roadmap wptrunner The automated test runner, commonly called through ./wpt run

Comments

@gsnedders
Copy link
Member

From executorselenium.py:

self.protocol.webdriver.set_window_size(600, 600)

This is the selenium.webdriver method, which sets the outer size of the browser window, and not the size of the viewport (including any scrollbars).
@gsnedders gsnedders added infra wptrunner The automated test runner, commonly called through ./wpt run priority:roadmap labels Aug 20, 2018
This was referenced Aug 20, 2018
Closed
Merged
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Aug 27, 2018
@gsnedders
Fix web-platform-tests#12578: make SeleniumExecutor use the right siz…
30637d9 
…e for reftests
@gsnedders gsnedders mentioned this issue Aug 27, 2018
Merged
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Aug 27, 2018
@gsnedders
fixup! Fix web-platform-tests#12578: make SeleniumExecutor use the ri…
3b99513 
…ght size for reftests
@mdittmer
Copy link
Contributor

friendly ping @gsnedders did 3b99513 get merged?

@gsnedders
Copy link
Member Author

@mdittmer No, was waiting on responses from some on #7598 (need to ping them), and needs changes in Gecko to actually work everywhere.

jgraham pushed a commit that referenced this issue Nov 9, 2018
@gsnedders @jgraham
Fix #12578: make SeleniumExecutor use the right size for reftests
91706bb
jgraham pushed a commit that referenced this issue Nov 9, 2018
@gsnedders @jgraham
Fix #12578: make SeleniumExecutor/WebDriverExecutor use the right siz…
0d10b3e 
…e for reftests
jgraham pushed a commit that referenced this issue Nov 12, 2018
@gsnedders @jgraham
Fix #12578: make SeleniumExecutor/WebDriverExecutor use the right siz…
947cdf4 
…e for reftests
jgraham pushed a commit that referenced this issue Nov 12, 2018
@gsnedders @jgraham
Fix #12578: make SeleniumExecutor/WebDriverExecutor use the right siz…
6486992 
…e for reftests
jgraham pushed a commit that referenced this issue Nov 14, 2018
@gsnedders @jgraham
Fix #12578: make SeleniumExecutor/WebDriverExecutor use the right siz…
9454b8e 
…e for reftests
jgraham pushed a commit that referenced this issue Jan 15, 2019
@gsnedders @jgraham
Fix #12578: make SeleniumExecutor/WebDriverExecutor use the right siz…
dc87d4c 
…e for reftests
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Jan 17, 2019
@gsnedders
Fix web-platform-tests#12578: make {Selenium,WebDriver} use the right…
44e7ad0 
… size for reftests

Also drop some dead code reading reftest.js.
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Jan 17, 2019
@gsnedders
Fix web-platform-tests#12578: make {Selenium,WebDriver} use the right…
b754ae6 
… size for reftests

Also drop some dead code reading reftest.js.
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Jan 17, 2019
@gsnedders
Fix web-platform-tests#12578: make {Selenium,WebDriver} use the right…
b79e775 
… size for reftests

Also drop some dead code reading reftest.js.
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Jan 17, 2019
@gsnedders
Fix web-platform-tests#12578: make {Selenium,WebDriver} use the right…
b2a0e8c 
… size for reftests

Also drop some dead code reading reftest.js.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infra priority:roadmap wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make reftests 800x600 everywhere gsnedders/web-platform-tests
2 participants
@gsnedders @mdittmer