Skip to content

Commit

Permalink
Include fragmentainer overflow when shifting grid breakpoints.
Browse files Browse the repository at this point in the history
Since we're already modifying fragmentainer_space (in
ShiftBreakpointIntoNextFragmentainer), it seems reasonable to bake
fragmentainer overflow directly into fragmentainer_space as well, so
that ShiftBreakpointIntoNextFragmentainer sets the correct row offset
adjustments.

Bug: 1430650
Change-Id: Idf987709247cd6c65ca7b83422195837c6e8f3da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4414602
Reviewed-by: Ian Kilpatrick <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1128736}
  • Loading branch information
mstensho authored and chromium-wpt-export-bot committed Apr 11, 2023
1 parent e1a70b0 commit ee00ae6
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions css/css-break/grid/monolithic-overflow-009.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<!DOCTYPE html>
<link rel="author" title="Morten Stenshorne" href="mailto:[email protected]">
<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=1430650">
<link rel="match" href="../../reference/ref-filled-green-100px-square.xht">
<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
<div style="columns:2; gap:0; column-fill:auto; width:100px; height:100px; background:red;">
<div style="display:grid; grid-template-rows:20px 100px;">
<div style="contain:size; height:150px;">
<div style="height:100px; background:green;"></div>
</div>
<div style="break-before:column; height:100px; background:green;"></div>
</div>
</div>

0 comments on commit ee00ae6

Please sign in to comment.