Skip to content

Commit

Permalink
[css-fonts] font-style: oblique 0deg should serialize as font-style: …
Browse files Browse the repository at this point in the history
…normal (#50429)

Updates font-style tests to match the CSS WG resolution on "font-style: oblique 0deg" serialization.

Export made from a WebKit repository (2f2b93f7).
  • Loading branch information
weinig authored Feb 3, 2025
1 parent 1e316b1 commit 7da77c4
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 7 deletions.
8 changes: 4 additions & 4 deletions css/css-fonts/animations/font-style-interpolation.html
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
}, [
{at: -2, expect: 'oblique -20deg'},
{at: -0.25, expect: 'oblique -2.5deg'},
{at: 0, expect: 'oblique 0deg'},
{at: 0, expect: 'normal'},
{at: 0.3, expect: 'oblique 3deg'},
{at: 0.6, expect: 'oblique 6deg'},
{at: 1, expect: 'oblique 10deg'},
Expand Down Expand Up @@ -74,7 +74,7 @@
}, [
{ at: -2, expect: 'oblique -40deg' },
{ at: -0.25, expect: 'oblique -5deg' },
{ at: 0, expect: 'oblique 0deg' },
{ at: 0, expect: 'normal' },
{ at: 0.3, expect: 'oblique 6deg' },
{ at: 0.6, expect: 'oblique 12deg' },
{ at: 1, expect: 'oblique 20deg' },
Expand All @@ -89,7 +89,7 @@
{ at: -1, expect: 'oblique 40deg' },
{ at: 0, expect: 'oblique 20deg' },
{ at: 0.5, expect: 'oblique 10deg' },
{ at: 1, expect: 'oblique 0deg' },
{ at: 1, expect: 'normal' },
{ at: 1.5, expect: 'oblique -10deg' },
]);

Expand All @@ -101,7 +101,7 @@
{ at: -2, expect: 'oblique -90deg' },
{ at: -1, expect: 'oblique -90deg' },
{ at: 0, expect: 'oblique -90deg' },
{ at: 0.5, expect: 'oblique 0deg' },
{ at: 0.5, expect: 'normal' },
{ at: 1, expect: 'oblique 90deg' },
{ at: 1.5, expect: 'oblique 90deg' },
]);
Expand Down
4 changes: 3 additions & 1 deletion css/css-fonts/parsing/font-style-computed.html
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,11 @@
test_computed_value('font-style', 'italic');
test_computed_value('font-style', 'oblique');

test_computed_value('font-style', 'oblique 0deg', 'normal');
test_computed_value('font-style', 'oblique calc(10deg - 10deg)', 'normal');

test_computed_value('font-style', 'oblique 10deg');
test_computed_value('font-style', 'oblique -10deg');
test_computed_value('font-style', 'oblique 0deg');
test_computed_value('font-style', 'oblique -90deg');
test_computed_value('font-style', 'oblique 90deg');
test_computed_value('font-style', 'oblique 10grad', 'oblique 9deg');
Expand Down
4 changes: 3 additions & 1 deletion css/css-fonts/parsing/font-style-valid.html
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,11 @@
test_valid_value('font-style', 'italic');
test_valid_value('font-style', 'oblique');

test_valid_value('font-style', 'oblique 0deg', 'normal');
test_valid_value('font-style', 'oblique calc(10deg - 10deg)', 'oblique calc(0deg)');

test_valid_value('font-style', 'oblique 10deg');
test_valid_value('font-style', 'oblique -10deg');
test_valid_value('font-style', 'oblique 0deg');
test_valid_value('font-style', 'oblique -90deg');
test_valid_value('font-style', 'oblique 90deg');
test_valid_value('font-style', 'oblique 10grad');
Expand Down
2 changes: 1 addition & 1 deletion css/css-fonts/variations/font-style-parsing.html
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
{ style: "italic 20deg", expectedResult: false, message: "'italic' followed by angle is invalid" },
{ style: "italic a", expectedResult: false, message: "'italic' followed by non-number is invalid" },
{ style: "oblique", expectedResult: true, message: "'oblique' is valid" },
{ style: "oblique 0deg", expectedResult: true, message: "'oblique' followed by zero degrees is valid" },
{ style: "oblique 0deg", expectedResult: true, message: "'oblique' followed by zero degrees is valid", expectedValue: "normal" },
{ style: "oblique 20deg", expectedResult: true, message: "'oblique' followed by positive angle in degrees is valid" },
{ style: "oblique 0.5rad", expectedResult: true, message: "'oblique' followed by positive angle in radians is valid", expectedValue: /^oblique 28\.\d*deg$/ },
{ style: "oblique 20grad", expectedResult: true, message: "'oblique' followed by positive angle in gradians is valid", expectedValue: "oblique 18deg" },
Expand Down

0 comments on commit 7da77c4

Please sign in to comment.