Miss the cache when truncated by the fragmentation line.

If a fragment got truncated by the fragmentation line, and the fragmentation line has moved (relatively to the fragment), we cannot re-use it. Fragments may get truncated if there's trailing margin or border-spacing. Also need to rebaseline fast/block/basic/align-attribute-ltr.html which got incorrectly rebaselined in CL:3829558 (must have drowned in all the other rebaseline noise there), and this is what allowed the border-spacing part of the issue to enter our codebase "unnoticed". The margin part is an old bug, though. Bug: 1368054 Change-Id: I226907a3a2af8cbe44e7871c7ae8bd038bc0d2ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3917855 Reviewed-by: Ian Kilpatrick <[email protected]> Commit-Queue: Morten Stenshorne <[email protected]> Cr-Commit-Position: refs/heads/main@{#1051968}
web-platform-tests · Sep 27, 2022 · 2fa24e2 · 2fa24e2
1 parent 51db598
commit 2fa24e2
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 0 deletions.
diff --git a/css/css-break/table/truncated-border-spacing-at-fragmentainer-end.html b/css/css-break/table/truncated-border-spacing-at-fragmentainer-end.html
@@ -0,0 +1,14 @@
+<!DOCTYPE html>
+<link rel="author" title="Morten Stenshorne" href="mailto:[email protected]">
+<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=1368054">
+<link rel="match" href="../../reference/ref-filled-green-100px-square.xht">
+<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
+<div id="mc" style="columns:1; column-fill:auto; width:100px; height:60px; background:red;">
+  <div style="display:table; width:100%; border-spacing:40px; background:green;">
+    <div style="height:20px;"></div>
+  </div>
+</div>
+<script>
+  document.body.offsetTop;
+  mc.style.height = "100px";
+</script>
diff --git a/css/css-break/truncated-margin-at-fragmentainer-end-001.html b/css/css-break/truncated-margin-at-fragmentainer-end-001.html
@@ -0,0 +1,14 @@
+<!DOCTYPE html>
+<link rel="author" title="Morten Stenshorne" href="mailto:[email protected]">
+<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=1368054">
+<link rel="match" href="../reference/ref-filled-green-100px-square.xht">
+<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
+<div id="mc" style="columns:1; column-fill:auto; width:100px; height:60px; background:red;">
+  <div style="display:flow-root; background:green;">
+    <div style="margin-bottom:40px; height:60px;"></div>
+  </div>
+</div>
+<script>
+  document.body.offsetTop;
+  mc.style.height = "100px";
+</script>
diff --git a/css/css-break/truncated-margin-at-fragmentainer-end-002.html b/css/css-break/truncated-margin-at-fragmentainer-end-002.html
@@ -0,0 +1,15 @@
+<!DOCTYPE html>
+<link rel="author" title="Morten Stenshorne" href="mailto:[email protected]">
+<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=1368054">
+<link rel="match" href="../reference/ref-filled-green-100px-square.xht">
+<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
+<div style="columns:1; column-fill:auto; width:100px; height:100px; background:red;">
+  <div id="child" style="height:40px;"></div>
+  <div style="display:flow-root; background:green;">
+    <div style="margin-bottom:40px; height:60px;"></div>
+  </div>
+</div>
+<script>
+  document.body.offsetTop;
+  child.style.height = "0";
+</script>