Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rounding logic for results page #4142

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

DanielRyanSmith
Copy link
Contributor

Fixes #4107

The test results page was handling score rounding slightly differently than the interop dashboard (rounding to the nearest whole percent rather than nearest tenth of a percent). In order to avoid rounding up to 100% in cases where there were still some tests/subtests failing, some logic was added to instead display the score as 99.9% in those cases. This created a situation in which the interop dashboard and the results page looked close enough to each other (99.7% vs. 99.9%) that it seemed as if there was a calculation error on one of the pages. I hadn't looked at this logic in some time and also assumed this was some calculation error. 😅

This very simple change makes it so the results page rounds the score in the same way as the interop dashboard, so this confusion will not come up again.

Before

C66AS3UueX5yAnL

After

7hqcLeTCmKGhfNA

Copy link
Collaborator

@jcscottiii jcscottiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A possible improvement would be to have a tooltip or alternative text that is initially hidden. When triggered (on hover or something else), it shows the precise number.

@DanielRyanSmith DanielRyanSmith merged commit a491f11 into main Dec 4, 2024
12 checks passed
@DanielRyanSmith DanielRyanSmith deleted the interop-score-rounding-fix branch December 4, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some Focus Area percentages on dashboard don't match the results percentage
2 participants