Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update score of interop '23 accessibility investigation #3541

Merged
merged 3 commits into from
Oct 18, 2023
Merged

update score of interop '23 accessibility investigation #3541

merged 3 commits into from
Oct 18, 2023

Conversation

cookiecrook
Copy link
Contributor

@cookiecrook cookiecrook commented Oct 13, 2023 •
edited
Loading

Description

Percentage update (87% -> 91%) for Accessibility Interop Investigation, based on scoring criteria:

@cookiecrook
Copy link
Contributor Author

@boazsender

cookiecrook
cookiecrook commented Oct 13, 2023
View reviewed changes
Copy link
Contributor Author

@cookiecrook cookiecrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Miscounted the first time. Corrected!

webapp/components/interop-data.js Outdated Show resolved Hide resolved
webapp/static/interop-data.json Outdated Show resolved Hide resolved
@cookiecrook
Apply suggestions from code review
af7c721 
m. correcting miscount.
@cookiecrook
Copy link
Contributor Author

@boazsender @KyleJu

Error: Error thrown outside of test function: Blocked a frame with origin "http://localhost:8081" from accessing a cross-origin frame.
  ChildRunner.loaded at /components/wct-browser-legacy/browser.js:633
           <unknown> at /components/wct-browser-legacy/browser.js:611

How to pass the unrelated(?) check failure?

@cookiecrook
Apply suggestions from code review
5461e91 
Another 1% merged in this morning.
@cookiecrook
Copy link
Contributor Author

cookiecrook commented Oct 13, 2023 •
edited
Loading

Sorry, I committed an update (+1% this morning) which dropped the prior check failure details link. I should have done this first and then asked the question if it failed again. FYI, it was in the web_components_test check.

@cookiecrook
Copy link
Contributor Author

Seems resolved. Please disregard.

@cookiecrook
Copy link
Contributor Author

We might get another +1% by EOD, so I'll recycle the review then.

@cookiecrook
Copy link
Contributor Author

That one is not going to happen today, so recycling review + automerge.

@cookiecrook cookiecrook mentioned this pull request Oct 14, 2023
Closed
@cookiecrook
Copy link
Contributor Author

@boazsender any idea why merging is blocked? You are the approving reviewer, but review is still required?

@KyleJu
Copy link
Collaborator

KyleJu commented Oct 17, 2023

@boazsender any idea why merging is blocked? You are the approving reviewer, but review is still required?

I stamped it and it should work now. Unsure why it was blocked

@cookiecrook
Copy link
Contributor Author

Just FYI I don't have merge access so one of you will need to do it. Thanks @KyleJu and @boazsender

@KyleJu KyleJu merged commit f64af03 into web-platform-tests:main Oct 18, 2023
12 checks passed
@KyleJu
Copy link
Collaborator

KyleJu commented Oct 18, 2023

Just FYI I don't have merge access so one of you will need to do it. Thanks @KyleJu and @boazsender

Done!

This was referenced Oct 21, 2023
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleJu KyleJu KyleJu approved these changes

@boazsender boazsender boazsender approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cookiecrook @KyleJu @boazsender