Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude false positive gosec rule #3470

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Exclude false positive gosec rule #3470

merged 2 commits into from
Aug 21, 2023

Conversation

KyleJu
Copy link
Collaborator

@KyleJu KyleJu commented Aug 21, 2023 •
edited
Loading

Fix CI issues in pending PRs. Annotate the false positive G101 rules

golangci/golangci-lint info checking GitHub for latest tag
golangci/golangci-lint info found version: 1.54.2 for v1.54.2/linux/amd64
golangci/golangci-lint info installed /go/bin/golangci-lint
golangci-lint run ./api/...
api/screenshot_redirect_handler.go:28:2: G101: Potential hardcoded credentials (gosec)
	bucket := "wptd-screenshots-staging"
	^
api/screenshot/cache.go:76:2: G101: Potential hardcoded credentials (gosec)
	bucketName := "wptd-screenshots-staging"
	^
make: *** [Makefile:77: golangci_lint] Error 1

@KyleJu KyleJu requested a review from jcscottiii August 21, 2023 19:55
@KyleJu KyleJu merged commit f486822 into main Aug 21, 2023
@KyleJu KyleJu deleted the go101 branch August 21, 2023 20:46
@KyleJu KyleJu mentioned this pull request Aug 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcscottiii jcscottiii jcscottiii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KyleJu @jcscottiii