Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing search results due to wildcard implementation #3448

Open
KyleJu opened this issue Aug 11, 2023 · 1 comment
Open

Missing search results due to wildcard implementation #3448

KyleJu opened this issue Aug 11, 2023 · 1 comment

Comments

@KyleJu
Copy link
Collaborator

KyleJu commented Aug 11, 2023 •
edited
Loading

See this comment for more details. On a high level, the for loop for !ok && len(dir) > 1 should not terminate as soon as a result is found, because a test can be triaged to multiple links and labels due to wildcards. It should find all labels and test links, as we it looks up all parent directories.
@KyleJu KyleJu mentioned this issue Aug 11, 2023
Merged
This was referenced Aug 22, 2023
Closed
Merged
@KyleJu
Copy link
Collaborator Author

KyleJu commented Aug 23, 2023

A comment for potential performance improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KyleJu