Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory labels are ignored when a file-specific label is applied #4665

Closed
cookiecrook opened this issue Aug 21, 2023 · 4 comments · Fixed by web-platform-tests/wpt.fyi#3472

Comments

@cookiecrook
Copy link
Contributor

cookiecrook commented Aug 21, 2023

Source excerpt from ./inert/META.yml

links:
    - label: a11y
      results:
        - test: "*"
    - label: accessibility
      results:
        - test: "*"
    - label: inert
      results:
        - test: "*"

The above works mostly as expected in this directory and others, applying all three labels to descendant files in the directory. However, when there is a file-specific label applied, the directories labels are overwritten.

    - label: interop-2023-inert
      results:
        - test: dynamic-inert-on-focused-element.html
        - test: inert-computed-style.html
        - test: inert-on-non-html.html
        - test: inert-on-slots.html
        - test: inert-with-modal-dialog-001.html
        - test: inert-canvas-fallback-content.html
        - test: inert-iframe-hittest.html
        - test: inert-iframe-tabbing.html
        - test: inert-label-focus.html
        - test: inert-node-is-uneditable.html
        - test: inert-node-is-unselectable.html
        - test: inert-with-modal-dialog-002.html
        - test: inert-inlines.html
        - test: inert-node-is-unfocusable.html
        - test: inert-pseudo-element-hittest.html
        - test: inert-svg-hittest.html
        - test: inert-and-contenteditable.html
        - test: inert-does-not-match-disabled-selector.html
        - test: inert-in-shadow-dom.html

In short, the above files do not show up in the following search, but should.

https://wpt.fyi/results/inert?label=master&label=experimental&aligned&q=label%3Aaccessibility

The only file that shows up in the results is the one without a file-specific label block test reference.

@cookiecrook
Copy link
Contributor Author

@KyleJu
Copy link
Contributor

KyleJu commented Aug 22, 2023

Related to https://github.com/web-platform-tests/wpt.fyi/issues/3448. I will give it a fix today

@KyleJu
Copy link
Contributor

KyleJu commented Aug 23, 2023

This will be alive in the next prod push, which should be thursday

@KyleJu
Copy link
Contributor

KyleJu commented Aug 25, 2023

Deployment is complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants