Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove interop-2021 label from tentative tests #2218

Closed
wants to merge 1 commit into from

Conversation

foolip
Copy link
Member

@foolip foolip commented Nov 30, 2021

@foolip foolip added the do not merge yet Disable auto-merge label Nov 30, 2021
@nt1m
Copy link
Member

nt1m commented Aug 5, 2022

@foolip Is this something we still want to do?

@foolip
Copy link
Member Author

foolip commented Aug 5, 2022

@nt1m I think we should review these tests and decide individually. IIRC I brought this up in a meeting, but we didn't give an action item to anyone so it's just sitting here.

As step 1 I'll rebase this to resolve conflicts.

@foolip foolip force-pushed the interop-2021-tentative branch from df02eda to f05f52a Compare August 5, 2022 13:31
@foolip
Copy link
Member Author

foolip commented Aug 5, 2022

So they're actually passing everywhere, making it low priority to figure out if they should be tentative still or not.

If someone would like to remove them an issue on https://github.com/web-platform-tests/interop-2022/issues would be the way to go. These test lists were reviewed when we agreed on Interop 2022, so we shouldn't drop them without discussion.

I'll mark this PR as draft since I'm not planning to do anything with it myself right now.

@foolip foolip marked this pull request as draft August 5, 2022 13:36
@foolip
Copy link
Member Author

foolip commented Aug 5, 2022

web-platform-tests/results-analysis#66 is the corresponding draft PR for the scoring script. (The Compat 2021 scoring script doesn't use the labels like Interop 2022 does.)

@foolip foolip closed this Apr 27, 2023
@foolip foolip deleted the interop-2021-tentative branch April 27, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge yet Disable auto-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants