Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand on "When to use the RFC process" #2

Merged
merged 3 commits into from
Jan 16, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,12 @@
Most changes in web-platform-tests can be made directly in pull requests
following the usual review process.

The RFC (request for comments) process is used to request wider review for
substantial changes, which might impact other stakeholders or users of
web-platform-tests.
This RFC (request for comments) process is used to request wider review.

## When to use the RFC process

A few examples where the process is
likely to be useful:
Use this process for substantial changes which might impact other stakeholders
or users of web-platform-tests. Examples of where it is likely to be useful:

- Changes in [resources/](https://github.com/web-platform-tests/wpt/tree/master/resources)
which would affect many test authors, such as extending testharness.js.
Expand All @@ -22,6 +20,13 @@ likely to be useful:
- Adding a new third-party code or service dependency.
- Changing review workflows or policies.

Cases where the RFC process need *not* be used:

- Introducing a new top-level directory for a new specification.
- Minor changes in behavior in where all call sites are known and accounted
for.
- Behavior-preserving refactoring with a low risk of regressions.

As a rule of thumb, please use the RFC process when it would be useful and err
foolip marked this conversation as resolved.
Show resolved Hide resolved
on the side of skipping it if in doubt!

Expand Down