Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carryover evaluation: Pointer and Mouse Events #809

Closed
nairnandu opened this issue Oct 7, 2024 · 7 comments
Closed

Carryover evaluation: Pointer and Mouse Events #809

nairnandu opened this issue Oct 7, 2024 · 7 comments
Labels
accepted An accepted proposal carryover-evaluation Evaluate whether to continue a focus area in the next year focus area: Pointer and Mouse Events

Comments

@nairnandu
Copy link
Contributor

Let's evaluate whether to continue the Pointer and Mouse Events focus area in Interop 2025

Carryover evaluation for Interop 2024: #472

Tests

We should also consider whether we should add tests for 2025.

@nairnandu nairnandu added focus area: Pointer and Mouse Events carryover-evaluation Evaluate whether to continue a focus area in the next year labels Oct 7, 2024
@mustaqahmed
Copy link
Member

mustaqahmed commented Feb 4, 2025

I am proposing to add these 7 WPTs to the "Failing tests" mentioned above, below are my comments why.

  • The following 5 tests are related to PEWG decisions in the last 2 years around DOM changes (e.g. pointerevents#457 and pointerevents#487.

    • pointerevents/pointerevent_lostpointercapture_for_disconnected_node.html: Seems easy to fix.
    • pointerevents/pointerevent_lostpointercapture_remove_setcapture_node.html: Perhaps a test problem.
    • pointerevents/pointerevent_pointer_boundary_events_after_removing_last_over_element.html
    • pointerevents/pointerevent_pointerout_no_pointer_movement.html: This got removed from Interop 2024 because of a spec conflict which has been fixed recently.
    • uievents/mouse/mousemove_after_mouseover_target_removed.html: closely related to the one above.
  • Miscellaneous:

    • pointerevents/pointerevent_click_on_chorded_mouse_button.tentative.html: Recent consensus on pointerevents#530.
    • pointerevents/pointerevent_pointerrawupdate.html: Easy to fix this minor failure.
    • pointerevents/pointerevent_setpointercapture_inactive_button_mouse.html: Perhaps a test problem.

@smaug---- @masayuki-nakano @aprotyas: Please let us know your thoughts.


Edit: crossed out one test and updated the WPT link accordingly.

@gsnedders
Copy link
Member

  • pointerevents/pointerevent_click_on_chorded_mouse_button.tentative.html: Recent consensus on pointerevents#530.

It's not immediately apparent from that issue that there is now consensus, given the most recent comment about the issue still says "regardless of which path we take for this issue"? It would be nice if the issue were up-to-date, if there is now consensus.

@mustaqahmed
Copy link
Member

  • pointerevents/pointerevent_click_on_chorded_mouse_button.tentative.html: Recent consensus on pointerevents#530.

It's not immediately apparent from that issue that there is now consensus, given the most recent comment about the issue still says "regardless of which path we take for this issue"? It would be nice if the issue were up-to-date, if there is now consensus.

Thanks @gsnedders for spotting this: the issue is still open and up-to-date with PEWG discussion. I will now edit my comment above to cross it out.

Also feel free to question my "easy" comments above if anyone even feels otherwise.

@aprotyas
Copy link
Member

The 7 remaining tests all look reasonable to add.

Also, why do you think pointerevents/pointerevent_setpointercapture_inactive_button_mouse.html is a test issue?

@mustaqahmed
Copy link
Member

The 7 remaining tests all look reasonable to add.

Thanks!

Also, why do you think pointerevents/pointerevent_setpointercapture_inactive_button_mouse.html is a test issue?

I could be wrong here but here is my guess: the test unnecessarily uses two different actions.send() calls, and it is possible for a browser (or a ChromeDriver) to assign two different pointerIds to mouse and still follow the spec. Note that PEWG recently clarified that the mouse pointerId does not have to be a constant.

@smaug----
Copy link

label=experimental

@wpt-interop
Copy link
Collaborator

Thank you for proposing Carryover evaluation: Pointer and Mouse Events for inclusion in Interop 2025.

We are pleased to let you know that this proposal was accepted as part of the Pointer and Mouse Events focus area. You can follow the progress of this focus area on the Interop 2025 dashboard.

For an overview of our process, see proposal selection. Thank you for contributing to Interop 2025!

Posted on behalf of the Interop team.

@foolip foolip closed this as completed Feb 17, 2025
@foolip foolip added the accepted An accepted proposal label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted An accepted proposal carryover-evaluation Evaluate whether to continue a focus area in the next year focus area: Pointer and Mouse Events
Projects
Status: Done
Development

No branches or pull requests

7 participants