dialog-show-modal.html test changed to depend on :modal pseudo-class #79
Labels
test-change-proposal
Proposal to add or remove tests for an interop area
Comments
foolip
added
the
test-change-proposal
|
WebKit implements it (not in latest STP though). I'd be OK either way, css/selectors/invalidation/modal-pseudo-class-in-has.html also covers it. Splitting it would work, though while we're there it'd be nice to clean up 2 tests with similar names: html/semantics/interactive-elements/the-dialog-element/dialog-showModal.html |
|
@josepharhar WDYT? |
Sounds good to me! I hope that making a separate test for :modal wouldn't be too much extra code/logic, but I can't tell for sure by skimming the new changes. |
nt1m
added a commit
to nt1m/wpt
that referenced
this issue
May 18, 2022
nt1m
added a commit
to nt1m/wpt
that referenced
this issue
May 18, 2022
nt1m
added a commit
to nt1m/wpt
that referenced
this issue
May 18, 2022
nt1m
added a commit
to nt1m/wpt
that referenced
this issue
May 18, 2022
nt1m
added a commit
to web-platform-tests/wpt
that referenced
this issue
May 18, 2022
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
May 24, 2022
…t :modal pseudo-class test, a=testonly Automatic update from web-platform-tests Clean up modal dialog tests and split out :modal pseudo-class test (#34107) Closes web-platform-tests/interop#79 -- wpt-commits: f4e735e4245973ad955ecadab644b71a3d4533df wpt-pr: 34107
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this issue
May 25, 2022
…t :modal pseudo-class test, a=testonly Automatic update from web-platform-tests Clean up modal dialog tests and split out :modal pseudo-class test (#34107) Closes web-platform-tests/interop#79 -- wpt-commits: f4e735e4245973ad955ecadab644b71a3d4533df wpt-pr: 34107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
web-platform-tests/wpt#33999 updated a test that's part of Interop 2022 to depend on
:modal, causing it to regress in all browsers, since nobody implements:modalyet.We should decide in the next meeting whether we're happy with this change, or if we should split the test to avoid the dependency, since
:modalwasn't even spec'd when Interop 2022 started.cc @nt1m
The text was updated successfully, but these errors were encountered: