-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove a couple of scroll snap tests tied to an open spec issue from Interop 2023 #602
Comments
I'm in favor of removing these tests from Interop 2023. |
cc @flackr for Chromium input. |
@foolip Since the tests are failing because of an open spec issue, I would suggest removing them from Interop. |
We have agreed on the linked issue that avoiding inner snap areas is expected and that the text does suggest this without prescribing exactly how it works. We haven't yet agreed on the exact behavior which is what we're attempting to do in w3c/csswg-drafts#9187. Would it make sense / can we have a high level test that inner areas are respected / avoided in a way that doesn't prescribe the exact behavior? @skobes-chromium Also, which tests are actually depending on this issue? As far as I can tell the ones listed do not contain or prescribe behaviors for nested snap areas - only the ones with -nested- in the name do. |
The plan is to make sure that we're not including any tests related to avoiding nested snap areas in 2023, but we would like to resolve and test these in 2024. @skobes-chromium is going to make sure that we've not accidentally included these in suites in 2023 and we can make the nested tests .tentative for now. |
Nested snap cases have been marked as tentative (crbug.com/1505893). |
@skobes-chromium Thanks for doing this! @hiikezoe Can you verify that all the relevant tests have been excluded from Interop 2023? |
It looks like the nested cases have been excluded, but some of tests which are not nested cases still remain. It's super unclear to me what the relation ship between them is. For example, changing-scroll-snap-align.html was tweaked in https://chromium-review.googlesource.com/c/chromium/src/+/4842691 which is, I believe, for one of the changes for nested cases. |
The new cases in changing-scroll-snap-align.html are
At a glance these both seemed reasonable to expect within the existing spec so I did not move them into .tentative. |
If the test change was unrelated to the nest fix, that's quite unfortunate that it was done along with the fix. :/ Moreover as I commented, to me the test change isn't compliant with the existing spec text, even if I have misunderstand the spec, Chrome also had misunderstood before the nested fix, Safari has misunderstood even now. That's clearly a thing needs a spec issue to make the text clearer? |
These were added for nested snap work on crbug.com/1467300, but the behavior is subject to an open spec issue as discussed at: web-platform-tests/interop#602 Bug: 1505893 Change-Id: Iaf9783f7220acc5eeb19387e57f6ec3f88bc19e2
These were added for nested snap work on crbug.com/1467300, but the behavior is subject to an open spec issue as discussed at: web-platform-tests/interop#602 Bug: 1505893 Change-Id: Iaf9783f7220acc5eeb19387e57f6ec3f88bc19e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5085089 Reviewed-by: David Awogbemila <[email protected]> Commit-Queue: Steve Kobes <[email protected]> Cr-Commit-Position: refs/heads/main@{#1233355}
These were added for nested snap work on crbug.com/1467300, but the behavior is subject to an open spec issue as discussed at: web-platform-tests/interop#602 Bug: 1505893 Change-Id: Iaf9783f7220acc5eeb19387e57f6ec3f88bc19e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5085089 Reviewed-by: David Awogbemila <[email protected]> Commit-Queue: Steve Kobes <[email protected]> Cr-Commit-Position: refs/heads/main@{#1233355}
These were added for nested snap work on crbug.com/1467300, but the behavior is subject to an open spec issue as discussed at: web-platform-tests/interop#602 Bug: 1505893 Change-Id: Iaf9783f7220acc5eeb19387e57f6ec3f88bc19e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5085089 Reviewed-by: David Awogbemila <[email protected]> Commit-Queue: Steve Kobes <[email protected]> Cr-Commit-Position: refs/heads/main@{#1233355}
@hiikezoe are there still tests in https://wpt.fyi/results/css?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&view=interop&q=label%3Ainterop-2022-scrolling that should be excluded? |
No. scroll-snap-writing-mode-000.html remains there, but I don't have any concrete evidences/argues that it should also be excluded. I just saw a comment which implies it's somewhat related to the nested change, so anyways that's fine for now. Thank you guys, @skobes-chromium, @flackr and @foolip. I am going to close this issue. |
…-snap-align.html as tentative., a=testonly Automatic update from web-platform-tests Mark two test cases from changing-scroll-snap-align.html as tentative. These were added for nested snap work on crbug.com/1467300, but the behavior is subject to an open spec issue as discussed at: web-platform-tests/interop#602 Bug: 1505893 Change-Id: Iaf9783f7220acc5eeb19387e57f6ec3f88bc19e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5085089 Reviewed-by: David Awogbemila <[email protected]> Commit-Queue: Steve Kobes <[email protected]> Cr-Commit-Position: refs/heads/main@{#1233355} -- wpt-commits: 7db499bf01c922eacee27edeb21db75356ee8178 wpt-pr: 43506
…-snap-align.html as tentative., a=testonly Automatic update from web-platform-tests Mark two test cases from changing-scroll-snap-align.html as tentative. These were added for nested snap work on crbug.com/1467300, but the behavior is subject to an open spec issue as discussed at: web-platform-tests/interop#602 Bug: 1505893 Change-Id: Iaf9783f7220acc5eeb19387e57f6ec3f88bc19e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5085089 Reviewed-by: David Awogbemila <awogbemilachromium.org> Commit-Queue: Steve Kobes <skobeschromium.org> Cr-Commit-Position: refs/heads/main{#1233355} -- wpt-commits: 7db499bf01c922eacee27edeb21db75356ee8178 wpt-pr: 43506 UltraBlame original commit: 186934d842a247a5e2e6af07e06e4c36373d6842
…-snap-align.html as tentative., a=testonly Automatic update from web-platform-tests Mark two test cases from changing-scroll-snap-align.html as tentative. These were added for nested snap work on crbug.com/1467300, but the behavior is subject to an open spec issue as discussed at: web-platform-tests/interop#602 Bug: 1505893 Change-Id: Iaf9783f7220acc5eeb19387e57f6ec3f88bc19e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5085089 Reviewed-by: David Awogbemila <awogbemilachromium.org> Commit-Queue: Steve Kobes <skobeschromium.org> Cr-Commit-Position: refs/heads/main{#1233355} -- wpt-commits: 7db499bf01c922eacee27edeb21db75356ee8178 wpt-pr: 43506 UltraBlame original commit: 186934d842a247a5e2e6af07e06e4c36373d6842
…-snap-align.html as tentative., a=testonly Automatic update from web-platform-tests Mark two test cases from changing-scroll-snap-align.html as tentative. These were added for nested snap work on crbug.com/1467300, but the behavior is subject to an open spec issue as discussed at: web-platform-tests/interop#602 Bug: 1505893 Change-Id: Iaf9783f7220acc5eeb19387e57f6ec3f88bc19e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5085089 Reviewed-by: David Awogbemila <awogbemilachromium.org> Commit-Queue: Steve Kobes <skobeschromium.org> Cr-Commit-Position: refs/heads/main{#1233355} -- wpt-commits: 7db499bf01c922eacee27edeb21db75356ee8178 wpt-pr: 43506 UltraBlame original commit: 186934d842a247a5e2e6af07e06e4c36373d6842
…-snap-align.html as tentative., a=testonly Automatic update from web-platform-tests Mark two test cases from changing-scroll-snap-align.html as tentative. These were added for nested snap work on crbug.com/1467300, but the behavior is subject to an open spec issue as discussed at: web-platform-tests/interop#602 Bug: 1505893 Change-Id: Iaf9783f7220acc5eeb19387e57f6ec3f88bc19e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5085089 Reviewed-by: David Awogbemila <[email protected]> Commit-Queue: Steve Kobes <[email protected]> Cr-Commit-Position: refs/heads/main@{#1233355} -- wpt-commits: 7db499bf01c922eacee27edeb21db75356ee8178 wpt-pr: 43506
As skobes told in the carryover evaluation issue for Interop 2024, some of scroll snap related tests in Interop 2023 have failed due to an open spec issue. So it would make sense to remove them from Interop 2023.
The affected tests in the list of the skobes comment are;
css/css-scroll-snap/input/snap-area-overflow-boundary.html
css/css-scroll-snap/overflowing-snap-areas.html
css/css-scroll-snap/scroll-snap-stop-002.html
css/css-scroll-snap/snap-after-relayout/changing-scroll-snap-align.html
And I believe
css/css-scroll-snap/snap-after-initial-layout/scroll-snap-writing-mode-000.html
is also one of such tests since the test has started failing both on Firefox and Safari since Chrome changed the test itself as well as they changed their behavior to address the open spec issue.
CC @skobes-chromium and @nt1m
The text was updated successfully, but these errors were encountered: