-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove wpt/webgl/idlharness.any.html & idlharness.any.worker.html from Interop list #363
Comments
@jgraham @zcorpan can you review for Gecko? @gsnedders @nt1m can you review for WebKit? |
Does this imply that you think no implementation should move to match what is currently spec'd, because that would be additional churn? If so, does the WG believe it should change the spec to match existing implementations?
There's relatively few tests in WPT for WebGL; from memory @Ms2ger had added them there at a point when submitting things to the Khronos test suite was relatively burdensome. If someone wants to move those to the WebGL test suite, I doubt there would be complaints? The idlharness tests probably make sense to keep in WPT, given we have all the machinery to both auto-update IDL fragments and |
It seems like a rather unfortunate situation for the working group to request by back channels that implementers ignore the specification it publishes. I have no opinion on the inclusion in the interop list, but tests matching the actual specification should definitely remain in wpt. (At least some of the failures seem to flag that the IDL in the specification is invalid, so that needs fixing anyway.) |
What are the concrete problems?
Is it a WebGL spec problem or IDL test harness problem? There are methods with same name, same amount of parameters, but different parameter types. Is this intentionally disallowed by some rule? Only thing I could find:
|
Excluding these from Interop 2023 is OK for Mozilla. |
I think the spec needs to be updated to match the real implementation
Adding @kenrussell to give more insights on this
I also believe those tests should continue live in WPT, they are catching the errors as they are supposed to. But I don't think they need to be in the interop 2023 test list as they haven't disturbed any developers in last 10 years. |
It would be fine to move the few wpt tests for WebGL into the conformance suite at https://github.com/KhronosGroup/WebGL . The WebGL working group would like to align all implementations with the specification, just without the time pressure of doing this in Interop 2023. Per @kkinnunen-apple 's comment above and looking at https://webidl.spec.whatwg.org/#idl-overloading , it looks like the Web IDL test harness's definition of illegal overloads is not correct, and that it's flagging some legal overloads in the WebGL specification. This needs to be studied in more depth and ironed out. |
FWIW, given this came up in the meeting: from a WebKit point of view we are fine with dropping these tests from Interop 2023, our primary concern was that the WG is actually tracking what appears to be interoperably failing—rather than just filing an issue here saying we shouldn't score that. Given @kkinnunen-apple filed KhronosGroup/WebGL#3542, we're fine with removing this; I just wanted to make sure the WG was actually tracking something for the failure on their side. |
Test List
wpt /webgl/idlharness.any.html
wpt /webgl/idlharness.any.worker.html
Rationale
These two tests are exercising the corner cases of the WebGL specification related to the prototype chain of JavaScript wrappers. The issues they revealed have existed for 10 years and have not disturbed any web developers. Note that no current browser passes these tests. These tests are not included in the WebGL conformance suite at https://github.com/KhronosGroup/WebGL as well.
Rather than churn all existing WebGL implementations, the WebGL working group thinks these tests should be removed from the Interop 2023 suite. WebGL working group also suggested that future WebGL tests be proposed for inclusion in the WebGL conformance suite itself, before being added to the Interop 2023 suite.
The text was updated successfully, but these errors were encountered: