Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[motion-1] Add coord-box motion path tests #334

Closed
danielsakhapov opened this issue May 16, 2023 · 6 comments
Closed

[motion-1] Add coord-box motion path tests #334

danielsakhapov opened this issue May 16, 2023 · 6 comments
Labels
focus area: Motion Path test-change-proposal Proposal to add or remove tests for an interop area

Comments

@danielsakhapov
Copy link

Test List

https://wpt.fyi/results/css/motion?label=master&label=experimental&aligned&q=offset-path-coord-box-001.html%20or%20offset-path-coord-box-002.html%20or%20offset-path-coord-box-003.html

Rationale

Test offset-path: coord-box behaviour
@danielsakhapov danielsakhapov added the test-change-proposal Proposal to add or remove tests for an interop area label May 16, 2023
@danielsakhapov
Copy link
Author

@BorisChiou @nt1m

@BorisChiou
Copy link
Member

I have been started to work on this and other basic shapes support. Thanks for adding these tests.

@nt1m
Copy link
Member

nt1m commented May 16, 2023

@nmoucht What do you think?

@nairnandu nairnandu mentioned this issue May 25, 2023
Closed
@nairnandu nairnandu mentioned this issue Jun 7, 2023
Closed
@nmoucht
Copy link

nmoucht commented Jun 7, 2023

@nmoucht What do you think?

I would probably change offset-path-coord-box-001.html to result in a transform without decimal values (or at least add some pixel tolerance), as chrome also appears to be failing this test. Besides that these seem fine.

Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 8, 2023
@danielsakhapov @chromium-wpt-export-bot
Remove wpt test for offset-path as incorrect
8627b15 
Resolved by: web-platform-tests/interop#334

Change-Id: Ic9ea1cccc454feb1c99f8dbe87357ef0a4b56ccf
@danielsakhapov
Copy link
Author

added some pixel tolerance, feel free to further change it if needed

Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 8, 2023
@danielsakhapov @chromium-wpt-export-bot
Add pixel tolerance for wpt test for offset-path: <coord-box>
5e37c89 
Resolved by: web-platform-tests/interop#334

Change-Id: I1c0e2a1b849a3dbc27d4bc29847f15f499e9dfe4
@foolip
Copy link
Member

foolip commented Jun 8, 2023

I've labeled the 3 tests in web-platform-tests/wpt-metadata#4314.

aarongable pushed a commit to chromium/chromium that referenced this issue Jun 8, 2023
@danielsakhapov
Add pixel tolerance for wpt test for offset-path: <coord-box>
8f6188b 
Resolved by: web-platform-tests/interop#334

Change-Id: I1c0e2a1b849a3dbc27d4bc29847f15f499e9dfe4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598153
Reviewed-by: Fredrik Söderquist <[email protected]>
Commit-Queue: Daniil Sakhapov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1154920}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 8, 2023
@danielsakhapov @chromium-wpt-export-bot
Add pixel tolerance for wpt test for offset-path: <coord-box>
822d950 
Resolved by: web-platform-tests/interop#334

Change-Id: I1c0e2a1b849a3dbc27d4bc29847f15f499e9dfe4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598153
Reviewed-by: Fredrik Söderquist <[email protected]>
Commit-Queue: Daniil Sakhapov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1154920}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 8, 2023
@danielsakhapov @chromium-wpt-export-bot
Add pixel tolerance for wpt test for offset-path: <coord-box>
25cd61f 
Resolved by: web-platform-tests/interop#334

Change-Id: I1c0e2a1b849a3dbc27d4bc29847f15f499e9dfe4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598153
Reviewed-by: Fredrik Söderquist <[email protected]>
Commit-Queue: Daniil Sakhapov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1154920}
nt1m pushed a commit to web-platform-tests/wpt-metadata that referenced this issue Jun 10, 2023
@wptfyibot
[Interop 2023] Tag coord-box motion path tests
7b8b9e1 
Co-authored-by: foolip <[email protected]>

Fixes web-platform-tests/interop#334
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jun 22, 2023
@danielsakhapov @moz-wptsync-bot
Bug 1837398 [wpt PR 40442] - Add pixel tolerance for wpt test for off…
4013ca7 
…set-path: <coord-box>, a=testonly

Automatic update from web-platform-tests
Add pixel tolerance for wpt test for offset-path: <coord-box>

Resolved by: web-platform-tests/interop#334

Change-Id: I1c0e2a1b849a3dbc27d4bc29847f15f499e9dfe4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598153
Reviewed-by: Fredrik Söderquist <[email protected]>
Commit-Queue: Daniil Sakhapov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1154920}

--

wpt-commits: 25cd61f8b73920580806784c56a918d8e15afd2c
wpt-pr: 40442
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this issue Jun 22, 2023
@danielsakhapov @moz-wptsync-bot
Bug 1837398 [wpt PR 40442] - Add pixel tolerance for wpt test for off…
5ed630c 
…set-path: <coord-box>, a=testonly

Automatic update from web-platform-tests
Add pixel tolerance for wpt test for offset-path: <coord-box>

Resolved by: web-platform-tests/interop#334

Change-Id: I1c0e2a1b849a3dbc27d4bc29847f15f499e9dfe4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598153
Reviewed-by: Fredrik Söderquist <[email protected]>
Commit-Queue: Daniil Sakhapov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1154920}

--

wpt-commits: 25cd61f8b73920580806784c56a918d8e15afd2c
wpt-pr: 40442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
focus area: Motion Path test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@zcorpan @foolip @nt1m @BorisChiou @danielsakhapov @nmoucht