Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse events on disabled input elements #27

Closed
jgraham opened this issue Nov 18, 2021 · 4 comments
Closed

Mouse events on disabled input elements #27

jgraham opened this issue Nov 18, 2021 · 4 comments
Labels
compat-bug-proposal Proposals for web compat bugs requires:tests Requires additional tests to be written
Milestone

Comments

@jgraham
Copy link
Contributor

jgraham commented Nov 18, 2021

Description
The spec requires that disabled form controls don't receive click events. Gecko follows this and also prevents further event propogation, but other browsers apply it to all mouse events and allow further event propogation (I think; more comprehensive tests are required). This has created a number of serious site compatibility issues.

Bug reports
https://bugzilla.mozilla.org/show_bug.cgi?id=1653882
https://webcompat.com/issues/65773
webcompat/web-bugs#73699
webcompat/web-bugs#72988

Specification
https://html.spec.whatwg.org/multipage/forms.html#enabling-and-disabling-form-controls:-the-disabled-attribute
whatwg/html#2368

Tests
https://wpt.fyi/results/html/semantics/forms/attributes-common-to-form-controls/disabled-elements-01.html?label=master&label=experimental&aligned but this case isn't covered.

This is a bug to include in #9

@jgraham jgraham added the compat-bug-proposal Proposals for web compat bugs label Nov 18, 2021
@gsnedders
Copy link
Member

This also appears in #11 (comment), albeit linking to further tests in https://wpt.fyi/results/dom/events/Event-dispatch-click.html?label=experimental&label=master&aligned (though again doesn't test propagation AFAICT).

@foolip foolip added the requires:tests Requires additional tests to be written label Dec 6, 2021
@foolip
Copy link
Member

foolip commented Dec 6, 2021

I've added the requires:tests label but presume that added a test is fairly trivial, so that's not a blocker in my mind.

@josepharhar
Copy link

I'm happy to work on this in chromium in 2022.

https://wpt.fyi/results/html/semantics/forms/attributes-common-to-form-controls/disabled-elements-01.html?label=master&label=experimental&aligned but this case isn't covered.

https://wpt.fyi/results/dom/events/Event-dispatch-click.html?label=experimental&label=master&aligned (though again doesn't test propagation AFAICT).

So between disabled-elements-01.html and Event-dispatch-click.html we still are missing a case?

though again doesn't test propagation AFAICT

Could you elaborate the propagation case? I'd be happy to add test coverage

@jgraham
Copy link
Contributor Author

jgraham commented Dec 8, 2021

https://bugzilla.mozilla.org/show_bug.cgi?id=1653882#c14 is relevant to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat-bug-proposal Proposals for web compat bugs requires:tests Requires additional tests to be written
Projects
None yet
Development

No branches or pull requests

4 participants