Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CSS property value vs CSS declaration consistent #969

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Make CSS property value vs CSS declaration consistent #969

merged 1 commit into from
Apr 26, 2024

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Apr 25, 2024

Both forms were previously used.

@foolip foolip requested review from captainbrosset and ddbeck April 25, 2024 16:14
@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Apr 25, 2024
@foolip
Copy link
Collaborator Author

foolip commented Apr 25, 2024

This the existing case of "CSS declaration" that I'm aligning with:

web-features/feature-group-definitions/sticky-positioning.yml

Line 2 in 57ad8a7

description: "The `position: sticky` CSS declaration positions an element in the normal flow until it crosses a specified threshold, at which points it becomes fixed (stuck) at that position."

I'm not opinionated about the wording, just the consistency.

captainbrosset
captainbrosset approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@captainbrosset captainbrosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like consistency

@foolip
Copy link
Collaborator Author

foolip commented Apr 26, 2024

@ddbeck I know you also like consistency, but do you like the term "CSS declaration"?

https://developer.mozilla.org/en-US/docs/Web/API/CSS_Object_Model/CSS_Declaration

ddbeck added a commit to ddbeck/web-features that referenced this pull request Apr 26, 2024
@ddbeck
Description style guide: prefer "declaration" over "property value"
dad3404 
Codifies web-platform-dx#969
@ddbeck ddbeck mentioned this pull request Apr 26, 2024
Merged
@ddbeck
Copy link
Collaborator

ddbeck commented Apr 26, 2024

@ddbeck I know you also like consistency, but do you like the term "CSS declaration"?

I certainly do #974

foolip pushed a commit that referenced this pull request Apr 26, 2024
@ddbeck
Description style guide: prefer "declaration" over "property value" (#…
efc458d 
…974)

Codifies #969
@foolip foolip merged commit 01e7536 into web-platform-dx:main Apr 26, 2024
3 checks passed
@foolip foolip deleted the css-property-value branch April 26, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

@captainbrosset captainbrosset captainbrosset approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@foolip @ddbeck @captainbrosset