Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WebVR feature (deprecated) #2512

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Add WebVR feature (deprecated) #2512

merged 4 commits into from
Jan 16, 2025

Conversation

Elchi3
Copy link
Collaborator

@Elchi3 Elchi3 commented Jan 9, 2025

@github-actions github-actions bot added feature definition Creating or defining new features or groups of features. tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings labels Jan 9, 2025
@Elchi3 Elchi3 mentioned this pull request Jan 9, 2025
Merged
ddbeck
ddbeck approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. Thank you, Florian! A couple of minor suggestions for you, but you're welcome to merge this after you've had a look.

features/webvr.yml Outdated Show resolved Hide resolved
scripts/specs.ts Outdated Show resolved Hide resolved
@ddbeck
Copy link
Collaborator

ddbeck commented Jan 16, 2025

Also this might need a merge from main and refresh due to mdn/browser-compat-data#25616.

@Elchi3 Elchi3 merged commit 06a9647 into web-platform-dx:main Jan 16, 2025
3 checks passed
@Elchi3 Elchi3 deleted the vr-deprecated branch January 16, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features. tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Elchi3 @ddbeck