Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add :has-slotted feature #2328

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Add :has-slotted feature #2328

merged 2 commits into from
Nov 26, 2024

Conversation

jamesnw
Copy link
Collaborator

@jamesnw jamesnw commented Nov 25, 2024

Because :has-slotted is tagged as web-features:slot in BCD, I needed to move the keys in slot to the yml to override.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Nov 25, 2024
ddbeck
ddbeck approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Feel free to merge after you consider my description suggestion.

features/has-slotted.yml Outdated Show resolved Hide resolved
@jamesnw @ddbeck
Update features/has-slotted.yml
3466120 
Co-authored-by: Daniel D. Beck <[email protected]>
@jamesnw jamesnw enabled auto-merge (squash) November 26, 2024 14:48
@jamesnw jamesnw merged commit a47e164 into web-platform-dx:main Nov 26, 2024
3 checks passed
@jamesnw jamesnw deleted the has-slotted branch November 26, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesnw @ddbeck