Add CSS numeric factory #2000
Merged
Add CSS numeric factory #2000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
ddbeck
requested changes
Oct 28, 2024
There was a problem hiding this comment.
Oh I like this approach. It's probably the right way to do it, until there's a long enough history of support to justify decomposing the keys into CSS features.
It's also similar to how we cover groups of (actual) CSS functions (like the trig functions).
Some suggestions, but I'd be happy to see this move forward.
features/css-numeric-factory.yml
Outdated
There was a problem hiding this comment.
→ numeric-factory-functions.yml
features/css-numeric-factory.yml
Outdated
| @@ -0,0 +1,67 @@ | |||
| name: CSS numeric factory functions | |||
There was a problem hiding this comment.
Suggested change
| name: CSS numeric factory functions | |
| name: Numeric factory functions |
features/css-numeric-factory.yml
Outdated
| @@ -0,0 +1,67 @@ | |||
| name: CSS numeric factory functions | |||
| description: The CSS numeric factory functions create a CSSUnitValue, for instance with `CSS.px(12)` or `CSS.kHz(440)`. | |||
There was a problem hiding this comment.
I think we should be careful not to imply that these are CSS functions, but rather a browser API. Maybe like this?
Suggested change
| description: The CSS numeric factory functions create a CSSUnitValue, for instance with `CSS.px(12)` or `CSS.kHz(440)`. | |
| description: The numeric factory functions, such as `CSS.px()` or `CSS.kHz()`, return a `CSSUnitValue` representing a CSS number value (as in `12px` or `440kHz`). |
features/css-numeric-factory.yml
Outdated
| @@ -0,0 +1,67 @@ | |||
| name: CSS numeric factory functions | |||
| description: The CSS numeric factory functions create a CSSUnitValue, for instance with `CSS.px(12)` or `CSS.kHz(440)`. | |||
| spec: https://drafts.css-houdini.org/css-typed-om-1/#numeric-factory | |||
There was a problem hiding this comment.
Maybe? Or cssom?
Suggested change
| spec: https://drafts.css-houdini.org/css-typed-om-1/#numeric-factory | |
| spec: https://drafts.css-houdini.org/css-typed-om-1/#numeric-factory | |
| group: css |
ddbeck
approved these changes
Oct 28, 2024
vwallen
pushed a commit
to oddbird/web-features
that referenced
this pull request
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternate breakout of the CSS Typed OM spec as discussed in #1847. Rather than putting
api.CSS.ch_staticwith thech unitfeature, this draws inspiration from MDN. https://developer.mozilla.org/en-US/docs/Web/API/CSS/factory_functions_staticDoes this work as a feature?