-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more fetch keys #1982
Add more fetch keys #1982
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My review approach here is a comparison against the burndown of non-deprecated and standardized BCD keys for the interfaces mentioned and so I found more keys to consider here. But it could also be that some keys want to live in a separate feature or already do, so take the suggestions as inspiration rather than blockers.
this is great, thanks! i found the additional keys in this PR... somewhere (?), so added them. definitely will add these others and see what it looks like. |
Aha i see your other patch now! I'll limit this to fetch, so we don't conflict, and you can do all the xhr additions in #1963. |
added all, looks good, thanks @Elchi3! |
Did a pass to see if any of these keys should be separate features. Caniuse doesn't break any sub features out, just has There's a multi-year trickle of additions for blob support, readable stream integration and misc bits and bobs, some of which are baseline false. There's nothing that seems to stand out from the implementation timeline, nor from the docs or dev comments/writing based on the searches I did. There aren't any keys that match the other sub-features (metadata and priority). So leaving it all in here for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this looks good to me. Great to see all ducks in a row for fetch. I think we can always move stuff out into a separate feature later if there is appetite.
No description provided.