-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Performance APIs #1934
Add Performance APIs #1934
Conversation
8fe4e2f
to
109bfe8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass review, but it's a big PR, so should get another review as well.
- 👍🏼 on the group rename
- 👍🏼 on removing
performance
from the feature names - 👍🏼 on overall feature breakdown/composition
- The descriptions seemed generally fine but IIRC we've tended away from using
interface
and instead making active descriptions of the implementation, should get a 2nd opinion here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bunch of ideas for you!
spec: https://wicg.github.io/element-timing/ | ||
group: performance | ||
compat_features: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should probably be something like html.global_attributes.elementtiming
in here, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, there isn't such a key in BCD. The docs have no compat table either. https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/elementtiming. Not sure if it is "global" either:
This attribute may be applied to
<img>
,<image>
elements inside an<svg>
, poster images of<video>
elements, elements which have a background-image, and elements containing text nodes, such as a<p>
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It turns out there's no actual specification for this (though its reflection is via Element
). I filed mdn/browser-compat-data#24788
Co-authored-by: Daniel D. Beck <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready, apart from some messes I made.
I caused the conflicts by merging a change to the specs drafts script. Merging main
, running update-drafts
on the affected specs, and refreshing the dist should fix it up nicely.
I also suggested some fixes to typos that I introduced.
Co-authored-by: Daniel D. Beck <[email protected]>
Thanks Daniel, I think I also caused a bit of a mess by manually updating drafts plus the latest BCD release actually contained new Performance API keys plus the new draft collection now also contains sub features without a spec_url. In theory it should be all fixed now and we can be sure that all keys have been mapped! |
spec: https://wicg.github.io/element-timing/ | ||
group: performance | ||
compat_features: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It turns out there's no actual specification for this (though its reflection is via Element
). I filed mdn/browser-compat-data#24788
Web features for the Performance APIs, see https://developer.mozilla.org/en-US/docs/Web/API/Performance_API
Adds a new "Performance" group consisting of these features: