Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ruby annotation layout properties and group #1898

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Adds ruby annotation layout properties and group #1898

merged 3 commits into from
Oct 8, 2024

Conversation

vwallen
Copy link
Contributor

@vwallen vwallen commented Oct 3, 2024

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Oct 3, 2024
jamesnw
jamesnw approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@jamesnw jamesnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

autonome
autonome requested changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@autonome autonome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove these keys from features/draft/spec/css-ruby-1.yml? Hmm, unless y'all haven't been doing that for CSS keys?

@jamesnw
Copy link
Collaborator

jamesnw commented Oct 7, 2024

Can you remove these keys from features/draft/spec/css-ruby-1.yml? Hmm, unless y'all haven't been doing that for CSS keys?

We haven't been removing them- for some reason I thought we were avoiding that to avoid merge conflicts. I'm fine either way?

@vwallen vwallen requested a review from autonome October 7, 2024 20:26
@autonome
Copy link
Collaborator

autonome commented Oct 8, 2024

Can you remove these keys from features/draft/spec/css-ruby-1.yml? Hmm, unless y'all haven't been doing that for CSS keys?

We haven't been removing them- for some reason I thought we were avoiding that to avoid merge conflicts. I'm fine either way?

Never mind in that case! I have been, likely because early on was told to do so. But since nothing actually tests the aggregate set of keys in the drafts folders against the completed keys, it doesn't really matter. Worst that happens is someone picks out keys in drafts to work on, and they've already been done. But I typically check keys first before starting work on anything, regardless.

@autonome autonome merged commit f2f1b2a into web-platform-dx:main Oct 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@autonome autonome autonome approved these changes

@jamesnw jamesnw jamesnw approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vwallen @jamesnw @autonome