Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logical properties #1736

Merged
merged 9 commits into from
Sep 18, 2024
Merged

Logical properties #1736

merged 9 commits into from
Sep 18, 2024

Conversation

jamesnw
Copy link
Collaborator

@jamesnw jamesnw commented Sep 5, 2024

An alternate feature set from this would be something like-

  • Logical border (perhaps split into -color, -style, -width, etc)
  • Logical clear
  • Logical float
  • Logical inset
  • Logical min and max size
  • Logical padding

And then have physical counterparts for each.

In looking at how people are talking about this feature, it seemed that people were more interested in Logical properties all together, in knowing that they could use -block-start instead of -top (in LTR, TTB writing mode) across properties.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Sep 5, 2024
Copy link
Collaborator

@autonome autonome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, logical properties are documented as a single feature across many guides, blogs, etc.

features/logical-properties.yml Outdated Show resolved Hide resolved
features/logical-properties.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thank you!

@@ -0,0 +1,91 @@
name: Logical properties
description: CSS logical properties control borders, size, margin and padding with directions and dimensions relative to the writing mode. For example, in a left to right, top to bottom writing mode, `block-end` refers to the bottom. Also known as flow relative.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: CSS logical properties control borders, size, margin and padding with directions and dimensions relative to the writing mode. For example, in a left to right, top to bottom writing mode, `block-end` refers to the bottom. Also known as flow relative.
description: CSS logical properties control borders, size, margin, and padding with directions and dimensions relative to the writing mode. For example, in a left to right, top to bottom writing mode, `block-end` refers to the bottom. Also known as flow relative.

@ddbeck ddbeck merged commit a1c1086 into web-platform-dx:main Sep 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants