-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add forced-colors #1651
Merged
Merged
Add forced-colors #1651
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
951b566
Add forced-colors
jamesnw 22b4ffd
Edit
jamesnw 85c2702
Merge branch 'main' into forced-colors
jamesnw 384f639
Merge branch 'main' of github.com:web-platform-dx/web-features into f…
jamesnw 470857e
Adjust forced colors description
jamesnw 36f3fcd
Update features/forced-colors.yml
jamesnw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| name: Forced colors | ||
| description: The `forced-colors` CSS @media rule detects when a user has chosen to use a forced colors mode, also known as high-contrast mode, and the `forced-color-adjust` CSS property sets whether forced colors apply to an element. | ||
| spec: | ||
| - https://drafts.csswg.org/mediaqueries-5/#forced-colors | ||
| - https://drafts.csswg.org/css-color-adjust-1/#forced-color-adjust-prop | ||
| group: css | ||
| status: | ||
| compute_from: css.at-rules.media.forced-colors | ||
| compat_features: | ||
| - css.at-rules.media.forced-colors | ||
| - css.properties.forced-color-adjust | ||
| - css.properties.forced-color-adjust.auto | ||
| - css.properties.forced-color-adjust.none | ||
| - css.properties.forced-color-adjust.preserve-parent-color | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| # Generated from: forced-colors.yml | ||
| # Do not edit this file by hand. Edit the source file instead! | ||
|
|
||
| status: | ||
| baseline: low | ||
| baseline_low_date: 2022-09-12 | ||
| support: | ||
| chrome: "89" | ||
| chrome_android: "89" | ||
| edge: "79" | ||
| firefox: "89" | ||
| firefox_android: "89" | ||
| safari: "16" | ||
| safari_ios: "16" | ||
| compat_features: | ||
| # ⬇️ Same status as overall feature ⬇️ | ||
| # baseline: low | ||
| # baseline_low_date: 2022-09-12 | ||
| # support: | ||
| # chrome: "89" | ||
| # chrome_android: "89" | ||
| # edge: "79" | ||
| # firefox: "89" | ||
| # firefox_android: "89" | ||
| # safari: "16" | ||
| # safari_ios: "16" | ||
| - css.at-rules.media.forced-colors | ||
|
|
||
| # baseline: false | ||
| # support: | ||
| # chrome: "89" | ||
| # chrome_android: "89" | ||
| # edge: "79" | ||
| # firefox: "113" | ||
| # firefox_android: "113" | ||
| - css.properties.forced-color-adjust | ||
| - css.properties.forced-color-adjust.auto | ||
| - css.properties.forced-color-adjust.none | ||
|
|
||
| # baseline: false | ||
| # support: | ||
| # chrome: "106" | ||
| # chrome_android: "106" | ||
| # edge: "106" | ||
| - css.properties.forced-color-adjust.preserve-parent-color |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use the feature without
forced-color-adjust? It seems that merely detecting forced colors mode without being able to change it wouldn't be useful.I wonder if we should just remove the
compute_fromrule here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use it without
forced-color-adjust. For example, you can add a border to a button if it otherwise gets styles from box-shadow, which is removed in forced colors mode. So, the at rule was functional beforeforced-color-adjustwas added.