Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Font variant group and members #1621

Merged
merged 31 commits into from
Aug 23, 2024
Merged

Add Font variant group and members #1621

merged 31 commits into from
Aug 23, 2024

Conversation

jamesnw
Copy link
Collaborator

@jamesnw jamesnw commented Aug 19, 2024

No description provided.

jamesnw added 16 commits August 16, 2024 14:37
@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Aug 19, 2024
@jamesnw jamesnw marked this pull request as ready for review August 19, 2024 21:03
@ddbeck ddbeck mentioned this pull request Aug 21, 2024
Open
6 tasks
ddbeck
ddbeck requested changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several suggestions and a couple of questions for you. Thank you!

features/font-feature-settings.yml Outdated Show resolved Hide resolved
features/font-feature-settings.yml Outdated Show resolved Hide resolved
features/font-feature-settings.yml Outdated Show resolved Hide resolved
features/font-feature-settings.yml Outdated Show resolved Hide resolved
features/font-kerning.yml Outdated Show resolved Hide resolved
features/font-variant-numeric.yml Outdated Show resolved Hide resolved
features/font-variant-position.yml Outdated Show resolved Hide resolved
features/font-variation-settings.yml Outdated Show resolved Hide resolved
features/font-variation-settings.yml Outdated Show resolved Hide resolved
features/font-variation-settings.yml Outdated Show resolved Hide resolved
@jamesnw jamesnw requested a review from ddbeck August 21, 2024 16:29
jamesnw
jamesnw commented Aug 21, 2024
View reviewed changes
features/font-language-override.yml Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddbeck Heads up that I added this after the initial review. Thanks!

@jamesnw jamesnw mentioned this pull request Aug 22, 2024
Open
ddbeck
ddbeck requested changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience, James—we're getting very close (and it'll be quite satisfying to land so many features at once).

features/font-variant-numeric.yml Outdated Show resolved Hide resolved
features/font-variant-position.yml Outdated Show resolved Hide resolved
features/font-variant.yml Outdated Show resolved Hide resolved
@jamesnw jamesnw requested a review from ddbeck August 23, 2024 12:05
@jamesnw
Copy link
Collaborator Author

jamesnw commented Aug 23, 2024

Thanks for your patience, James—we're getting very close (and it'll be quite satisfying to land so many features at once).

And thanks for your patience and helpful reviews!

ddbeck
ddbeck approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ddbeck ddbeck merged commit 0af6428 into web-platform-dx:main Aug 23, 2024
3 checks passed
@jamesnw jamesnw deleted the font-variant branch August 23, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesnw @ddbeck