-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user-select #1602
Add user-select #1602
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-review before @ddbeck.
Minor description suggestion, but looks good otherwise.
I think a larger Selection
feature could make sense, but doesn't need to block this - can merge when we get there. I suspect it ends up being >1 feature, whether this particular bit is integrated or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to always leaving a comment w/ the reason for using compute_from
, I'm going to do this as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why caniuse only has such a specific key available, but otherwise this looks good to me.
name: user-select | ||
description: The `user-select` CSS property controls which elements can be selected by the user. | ||
spec: https://drafts.csswg.org/css-ui-4/#content-selection | ||
caniuse: user-select-none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting that Caniuse tracks only the none
value, when it seems like most of the other values for user-select
shipped at the same time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
caniuse often tracks unusual features, especially for relatively historic features that predate caniuse's BCD integration. Developers request coverage of specific features and Alexis makes a determination, so we can tell from this that somebody cared a lot about this value and hardly at all about the rest.
name: user-select | ||
description: The `user-select` CSS property controls which elements can be selected by the user. | ||
spec: https://drafts.csswg.org/css-ui-4/#content-selection | ||
caniuse: user-select-none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
caniuse often tracks unusual features, especially for relatively historic features that predate caniuse's BCD integration. Developers request coverage of specific features and Alexis makes a determination, so we can tell from this that somebody cared a lot about this value and hardly at all about the rest.
Co-authored-by: Daniel D. Beck <[email protected]>
I'm opening this, but wondering if this should be part of a larger "selection" feature, with the Selection API and the
::selection
pseudoselector. Thoughts?