Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user-select #1602

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Add user-select #1602

merged 5 commits into from
Sep 6, 2024

Conversation

jamesnw
Copy link
Collaborator

@jamesnw jamesnw commented Aug 15, 2024

I'm opening this, but wondering if this should be part of a larger "selection" feature, with the Selection API and the ::selection pseudoselector. Thoughts?

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Aug 15, 2024
Copy link
Collaborator

@autonome autonome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-review before @ddbeck.

Minor description suggestion, but looks good otherwise.

I think a larger Selection feature could make sense, but doesn't need to block this - can merge when we get there. I suspect it ends up being >1 feature, whether this particular bit is integrated or not.

features/user-select.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to always leaving a comment w/ the reason for using compute_from, I'm going to do this as well.

Copy link
Contributor

@mirisuzanne mirisuzanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why caniuse only has such a specific key available, but otherwise this looks good to me.

name: user-select
description: The `user-select` CSS property controls which elements can be selected by the user.
spec: https://drafts.csswg.org/css-ui-4/#content-selection
caniuse: user-select-none
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that Caniuse tracks only the none value, when it seems like most of the other values for user-select shipped at the same time?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

caniuse often tracks unusual features, especially for relatively historic features that predate caniuse's BCD integration. Developers request coverage of specific features and Alexis makes a determination, so we can tell from this that somebody cared a lot about this value and hardly at all about the rest.

name: user-select
description: The `user-select` CSS property controls which elements can be selected by the user.
spec: https://drafts.csswg.org/css-ui-4/#content-selection
caniuse: user-select-none
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

caniuse often tracks unusual features, especially for relatively historic features that predate caniuse's BCD integration. Developers request coverage of specific features and Alexis makes a determination, so we can tell from this that somebody cared a lot about this value and hardly at all about the rest.

features/user-select.yml Outdated Show resolved Hide resolved
@jamesnw jamesnw requested a review from ddbeck September 6, 2024 13:00
@ddbeck ddbeck merged commit fd2266a into web-platform-dx:main Sep 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants