-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Intl #1601
Add Intl #1601
Conversation
I opened mdn/browser-compat-data#24148 for the second point. |
The Edit: Also, we only get tag changes here when there's a BCD release. |
hm, but when I add the keys here, the tests fail due to key assignments to more than one group. |
Right. You'll need to have |
So I've been looking at this one and getting a bit frustrated. There's some evidence that developers see I suspect this is a case where I'm not sure the finished proposals are especially helpful in this either, though, since they're also a messy set of incremental steps. I wonder: what would this look like if we broke it up thematically (approximately one feature per |
Yeah, this is not trivial.
I think I did this already. The rest of the Intl API has seen separate pull requests with their own features. This PR has three namespaces together as I think the initial Intl API with the basic functionality is Collator, DateTimeFormat and NumberFormat. The tricky part now is that these namespaces (and others) have seen certain incremental enhancements with cannot be summarized easily. (sometimes you see things like "NumberFormat v3" but that doesn't seem to be very useful to web developers either and is more a snapshot than a feature per se). I'm leaning towards keeping this as is and splitting things out later if needed. https://web-platform-dx.github.io/web-features-explorer/groups/ (Groups -> JavaScript -> Intl) looks okay to me if it gains an "Intl" feature for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, thank you, Florian!
I have two suggestions for you and you're welcome to merge this after resolving them, one way or another. 😄
Thanks Daniel, I will leave this open until we have a BCD in |
So, I'm encountering two tricky things here.
(As you might have noticed already), I'm not a fan of
compute_from
, but I used it here.Over the years, a lot of things have been added to Intl. When the additions are entirely new built-ins, I added separate features for them (see my PRs from earlier this week). It gets more tricky with additions to existing built-ins, though, because it is harder to describe them as a package.
So, this is again a question of how/if to split things out or not. A list of proposals can be found here: https://github.com/tc39/proposals/blob/HEAD/ecma402/finished-proposals.md which provides some hints towards packaging things up in more features. Maybe we want to do that for the baseline low features at least? Otherwise, as it is recorded now,
Intl
will just be baseline high and we're done.I'd like to move some keys to the intl feature. I currently commented them out:
I believe I have to remove the tags from BCD for this to happen? (Definitely an interesting learning for our syncing work for BCD<->web-features.)