Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GeoLocation #1593

Merged
merged 5 commits into from
Aug 16, 2024
Merged

Add GeoLocation #1593

merged 5 commits into from
Aug 16, 2024

Conversation

petele
Copy link
Collaborator

@petele petele commented Aug 14, 2024

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Aug 14, 2024
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions. I think this needs one more key and a refreshed dist file, too.

features/geolocation.yml Outdated Show resolved Hide resolved
features/geolocation.yml Show resolved Hide resolved
features/geolocation.yml Outdated Show resolved Hide resolved
spec: https://w3c.github.io/geolocation/
status:
compute_from: api.Navigator.geolocation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This correctly aligns with caniuse (even though the GeolocationPosition story is weird). 👍

@petele petele requested a review from ddbeck August 15, 2024 14:09
features/geolocation.yml Show resolved Hide resolved
@ddbeck ddbeck merged commit 84c12f1 into web-platform-dx:main Aug 16, 2024
3 checks passed
@petele petele deleted the geoloc branch August 16, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants