-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TC39 float16array #1530
Add TC39 float16array #1530
Conversation
Hi @autonome, thanks for this PR! My main piece of feedback here is that we've tended to avoid features that aren't supported by any browser yet, although we do have a few such high-profile features, such as Masonry and Temporal. From https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Float16Array#browser_compatibility it looks like this is coming in Firefox 129. The data came from mdn/browser-compat-data#23730 which I think we can trust. But if we wait until next week we'll be able to see that everything is as expected, and avoid having to update the feature if some part didn't ship. For the feature ID and filename, I'd suggest just |
Yes, search caniuse.com. In this case, there is no feature, so nothing to add.
Please use the
It is correct currently, because Firefox 129 hasn't been released yet. The value is documented here, and means it's not Baseline: Line 36 in ae7d920
Include both, and more generally anything that is a part of the feature and shipped at the same time. The reason the constructor didn't show up in the spec draft here is because the spec link in BCD is to another spec: That's OK, but it's still part of |
No changes are needed here because of it, but I thought you'd be interested to know this came up in conversation on #1567 (review) |
Co-authored-by: Florian Scholz <[email protected]>
…eatures into tc39-float16array
@Elchi3 thanks! feel free to review or just fold into your ongoing JS work, i had just picked it up as an example early on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @autonome! I think we're good to go with this one! 👍
false
doesn't seem to be documented in either the draft contributor guide nor the baseline doc linked there