-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add <form>
element
#1440
Add <form>
element
#1440
Conversation
This is a bit similar to @petele if we called this "Forms" like "Tables", are there any additional bits you think should be included, that don't make sense as standalone features? Also paging @captainbrosset @ddbeck for thoughts on feature organization. |
I'll advocate for creating a separate feature for each of the
|
What about splitting the difference a little bit? I could imagine some sort foundational Forms feature consisting of a really, really stripped down thing:
It'd be part of the forms group, but it'd let us be free to handle the various input types as separate features. |
I'm not yet convinced combining them is the way to go. Including some keys but not others feels very arbitrary, and adds complexity about where someone might find something. Is it in the core Form feature, or is it in the element? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Safari showing DOM API support before the element itself is a bit weird. I filed mdn/browser-compat-data#24135 as an experiment. Hoping that Florian et al. have some feedback on whether I/we should be doing that routinely.
Also, for posterity: I haven't changed my mind exactly on the organization here, but I do feel like we might compose a feature, as suggested in #971. I think it'll be easier to sort out when we have all of the forms stuff complete. |
Used
compute_from: html.elements.form