Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a comment for empty dist files #1329

Closed
wants to merge 1 commit into from

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Jul 5, 2024

This is to have something to search for, and another step towards always
having a dist file.

This is to have something to search for, and another step towards always
having a dist file.
@@ -2,3 +2,5 @@
# Do not edit this file by hand. Edit the source file instead!

{}

# Nothing is generated, nothing to see here.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of linking out to some documentation (you can just stub a heading for now, if you like) to handle the whole "why is it empty?" question?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although, maybe it's better to link to the docs at the top of all dist files?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this. Linking to the docs on line 3 of all dist files (right after asking people not to edit the file by hand) would give them a friendly way to learn more, especially for folks who prefer to jump in the code first, and read docs later.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I've sent #1345 as a draft, to land after #1330.

If the docs mention {} then I don't think this PR is needed at all.

@foolip foolip closed this Jul 10, 2024
@foolip foolip deleted the empty-dist branch July 10, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants