Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add localeRedirect option to theme config #865

Merged
merged 3 commits into from
Mar 29, 2024
Merged

feat: add localeRedirect option to theme config #865

merged 3 commits into from
Mar 29, 2024

Conversation

ambar
Copy link
Contributor

@ambar ambar commented Mar 25, 2024

Summary

  1. Redirecting is unexpected when sharing the specific locale.
  2. It's hard to write a match function for every case, even if there is a guideline (such as https://datatracker.ietf.org/doc/html/rfc4647#section-3.4), locale codes may be too complex.

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

@netlify Netlify
Copy link

netlify bot commented Mar 25, 2024 •
edited
Loading

✅ Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 6a7b74b
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/66067876a674f80008eb5397
😎 Deploy Preview https://deploy-preview-865--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 93 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ambar ambar force-pushed the feat-redirectToCloestLocale branch from 124542c to d18ef39 Compare March 29, 2024 07:31
@ambar ambar changed the title feat: add redirectToCloestLocale option to theme config feat: add localeRedirect option to theme config Mar 29, 2024
chenjiahan
chenjiahan previously approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chenjiahan chenjiahan enabled auto-merge (squash) March 29, 2024 07:36
@Timeless0911 Timeless0911 force-pushed the feat-redirectToCloestLocale branch from 7fdb577 to 6a7b74b Compare March 29, 2024 08:14
@chenjiahan chenjiahan merged commit 94e1b0f into web-infra-dev:main Mar 29, 2024
9 checks passed
@chenjiahan chenjiahan mentioned this pull request Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timeless0911 Timeless0911 Timeless0911 approved these changes

@chenjiahan chenjiahan chenjiahan left review comments

Assignees
No one assigned
Labels
change: feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ambar @chenjiahan @Timeless0911