Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme): replace angle brackets in inline markdown #840

Merged
merged 1 commit into from
Mar 23, 2024
Merged

fix(theme): replace angle brackets in inline markdown #840

merged 1 commit into from
Mar 23, 2024

Conversation

10Derozan
Copy link
Contributor

Summary

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

@netlify Netlify
Copy link

netlify bot commented Mar 21, 2024 •
edited
Loading

✅ Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit b6e0d99
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/65fc31bd555329000806bcbf
😎 Deploy Preview https://deploy-preview-840--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 78 (🔴 down 7 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Huxpro
Huxpro reviewed Mar 21, 2024
View reviewed changes
Copy link
Contributor

@Huxpro Huxpro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope this works! Have you tested locally that this works for the internal website?

packages/theme-default/src/logic/utils.ts Show resolved Hide resolved
@10Derozan
Copy link
Contributor Author

Hope this works! Have you tested locally that this works for the internal website?

yeah, I have tested yet.

@10Derozan 10Derozan enabled auto-merge (squash) March 22, 2024 06:47
@10Derozan 10Derozan merged commit 1bef4dc into main Mar 23, 2024
9 checks passed
@10Derozan 10Derozan deleted the fix/render-inline-markdown branch March 23, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huxpro Huxpro Huxpro left review comments

@sanyuan0704 sanyuan0704 sanyuan0704 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@10Derozan @Huxpro @sanyuan0704