Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme-default): preserve query string on locale change #809

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

ambar
Copy link
Contributor

@ambar ambar commented Mar 18, 2024

Summary

It's useful when you use custom filter/tabs in your site and you want to keep the state on locale change.

The hash could be preserved as well, but it's not common as the query string. (eg. when using Docusaurus, the query string and hash are both preserved: https://docusaurus.io/docs/markdown-features/tabs?current-os=android#query-string)

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit c049eee
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/65f7cae10382d700082b677e
😎 Deploy Preview https://deploy-preview-809--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 83 (🔴 down 9 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@sanyuan0704 sanyuan0704 merged commit d27c2e2 into web-infra-dev:main Mar 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants