feat(hook): add optimizeModules hook
#2758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8c343dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
IWANABETHATGUY
force-pushed
the
feat/optimize-modules-hook
branch
from
4bf8fe6
to
a596b19
Compare
|
looks good to me, @jerrykingxyz would you mind having a look if this pr fits your needs? |
IWANABETHATGUY
force-pushed
the
feat/optimize-modules-hook
branch
from
a596b19
to
f709015
Compare
|
One more thing, you should add your newly added hooks here to make the hooks filter work, https://github.com/web-infra-dev/rspack/pull/2758/files#diff-65c9f2211aa3417321f820555fd1ec4a9647fdc6cba3c80c2b96587a4d4ad4fdR330-R331 |
IWANABETHATGUY
force-pushed
the
feat/optimize-modules-hook
branch
from
73fa2ae
to
8c343dc
Compare
hyf0
changed the title
optimizeModules hook
Merged
siyou
pushed a commit
to siyou/rspack
that referenced
this pull request
May 14, 2023
* feat(hook): add optimizeModules hook * fix(hook): call updateDisabledHooks method * fix(hook): add optimizeModules to hookMap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue (if exists)
fix #2423