revert: fix: align amd option behavior with webpack (#9103)

web-infra-dev · Jan 23, 2025 · 66c5e0d · 66c5e0d · github-actions · Jan 23, 2025
1 parent 9df4956
commit 66c5e0d
Show file tree

Hide file tree

Showing 88 changed files with 218 additions and 145 deletions.
diff --git a/crates/rspack_plugin_javascript/src/parser_plugin/amd/amd_define_dependency_parser_plugin.rs b/crates/rspack_plugin_javascript/src/parser_plugin/amd/amd_define_dependency_parser_plugin.rs
@@ -289,10 +289,6 @@ impl AMDDefineDependencyParserPlugin {
           }
         } else {
           // define([…], …)
-          if !first_arg.expr.is_array() {
-            return None;
-          }
-
           array = Some(&first_arg.expr);
 
           if is_callable(&second_arg.expr) {

diff --git a/crates/rspack_plugin_javascript/src/parser_plugin/amd/amd_plugin.rs b/crates/rspack_plugin_javascript/src/parser_plugin/amd/amd_plugin.rs
@@ -141,6 +141,26 @@ impl JavascriptParserPlugin for AMDParserPlugin {
     None
   }
 
+  fn identifier(
+    &self,
+    parser: &mut JavascriptParser,
+    ident: &swc_core::ecma::ast::Ident,
+    for_name: &str,
+  ) -> Option<bool> {
+    if for_name == DEFINE {
+      parser
+        .presentational_dependencies
+        .push(Box::new(ConstDependency::new(
+          ident.span().real_lo(),
+          ident.span().real_hi(),
+          RuntimeGlobals::AMD_DEFINE.name().into(),
+          Some(RuntimeGlobals::AMD_DEFINE),
+        )));
+      return Some(true);
+    }
+    None
+  }
+
   fn evaluate_identifier(
     &self,
     _parser: &mut JavascriptParser,

diff --git a/.../normalCases/amd/define-function/index.js → .../configCases/amd/define-function/index.js b/.../normalCases/amd/define-function/index.js → .../configCases/amd/define-function/index.js
diff --git a/...ts/normalCases/amd/define-function/lib.js → ...ts/configCases/amd/define-function/lib.js b/...ts/normalCases/amd/define-function/lib.js → ...ts/configCases/amd/define-function/lib.js
diff --git a/packages/rspack-test-tools/tests/configCases/amd/define-function/rspack.config.js b/packages/rspack-test-tools/tests/configCases/amd/define-function/rspack.config.js
@@ -0,0 +1,4 @@
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	amd: {},
+};
diff --git a/...ts/normalCases/amd/define-object/index.js → ...ts/configCases/amd/define-object/index.js b/...ts/normalCases/amd/define-object/index.js → ...ts/configCases/amd/define-object/index.js
diff --git a/...ests/normalCases/amd/define-object/lib.js → ...ests/configCases/amd/define-object/lib.js b/...ests/normalCases/amd/define-object/lib.js → ...ests/configCases/amd/define-object/lib.js
diff --git a/packages/rspack-test-tools/tests/configCases/amd/define-object/rspack.config.js b/packages/rspack-test-tools/tests/configCases/amd/define-object/rspack.config.js
@@ -0,0 +1,4 @@
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	amd: {},
+};
diff --git a/...ts/normalCases/amd/define-others/hello.js → ...ts/configCases/amd/define-others/hello.js b/...ts/normalCases/amd/define-others/hello.js → ...ts/configCases/amd/define-others/hello.js
diff --git a/...ts/normalCases/amd/define-others/index.js → ...ts/configCases/amd/define-others/index.js b/...ts/normalCases/amd/define-others/index.js → ...ts/configCases/amd/define-others/index.js
diff --git a/...alCases/amd/define-others/lucky-number.js → ...igCases/amd/define-others/lucky-number.js b/...alCases/amd/define-others/lucky-number.js → ...igCases/amd/define-others/lucky-number.js
diff --git a/packages/rspack-test-tools/tests/configCases/amd/define-others/rspack.config.js b/packages/rspack-test-tools/tests/configCases/amd/define-others/rspack.config.js
@@ -0,0 +1,4 @@
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	amd: {},
+};
diff --git a/...s/normalCases/amd/define-with-deps/add.js → ...s/configCases/amd/define-with-deps/add.js b/...s/normalCases/amd/define-with-deps/add.js → ...s/configCases/amd/define-with-deps/add.js
diff --git a/...alCases/amd/define-with-deps/constants.js → ...igCases/amd/define-with-deps/constants.js b/...alCases/amd/define-with-deps/constants.js → ...igCases/amd/define-with-deps/constants.js
diff --git a/...normalCases/amd/define-with-deps/hello.js → ...configCases/amd/define-with-deps/hello.js b/...normalCases/amd/define-with-deps/hello.js → ...configCases/amd/define-with-deps/hello.js
diff --git a/...normalCases/amd/define-with-deps/index.js → ...configCases/amd/define-with-deps/index.js b/...normalCases/amd/define-with-deps/index.js → ...configCases/amd/define-with-deps/index.js
diff --git a/...s/normalCases/amd/define-with-deps/lib.js → ...s/configCases/amd/define-with-deps/lib.js b/...s/normalCases/amd/define-with-deps/lib.js → ...s/configCases/amd/define-with-deps/lib.js
diff --git a/packages/rspack-test-tools/tests/configCases/amd/define-with-deps/rspack.config.js b/packages/rspack-test-tools/tests/configCases/amd/define-with-deps/rspack.config.js
@@ -0,0 +1,4 @@
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	amd: {},
+};
diff --git a/...normalCases/amd/define-with-name/index.js → ...configCases/amd/define-with-name/index.js b/...normalCases/amd/define-with-name/index.js → ...configCases/amd/define-with-name/index.js
diff --git a/...ormalCases/amd/define-with-name/jquery.js → ...onfigCases/amd/define-with-name/jquery.js b/...ormalCases/amd/define-with-name/jquery.js → ...onfigCases/amd/define-with-name/jquery.js
diff --git a/...s/normalCases/amd/define-with-name/lib.js → ...s/configCases/amd/define-with-name/lib.js b/...s/normalCases/amd/define-with-name/lib.js → ...s/configCases/amd/define-with-name/lib.js
diff --git a/packages/rspack-test-tools/tests/configCases/amd/define-with-name/rspack.config.js b/packages/rspack-test-tools/tests/configCases/amd/define-with-name/rspack.config.js
@@ -0,0 +1,4 @@
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	amd: {},
+};
diff --git a/...sts/normalCases/amd/define-wrapper/add.js → ...sts/configCases/amd/define-wrapper/add.js b/...sts/normalCases/amd/define-wrapper/add.js → ...sts/configCases/amd/define-wrapper/add.js
diff --git a/...rmalCases/amd/define-wrapper/constants.js → ...nfigCases/amd/define-wrapper/constants.js b/...rmalCases/amd/define-wrapper/constants.js → ...nfigCases/amd/define-wrapper/constants.js
diff --git a/...s/normalCases/amd/define-wrapper/hello.js → ...s/configCases/amd/define-wrapper/hello.js b/...s/normalCases/amd/define-wrapper/hello.js → ...s/configCases/amd/define-wrapper/hello.js
diff --git a/...s/normalCases/amd/define-wrapper/index.js → ...s/configCases/amd/define-wrapper/index.js b/...s/normalCases/amd/define-wrapper/index.js → ...s/configCases/amd/define-wrapper/index.js
diff --git a/...ts/normalCases/amd/define-wrapper/lib1.js → ...ts/configCases/amd/define-wrapper/lib1.js b/...ts/normalCases/amd/define-wrapper/lib1.js → ...ts/configCases/amd/define-wrapper/lib1.js
diff --git a/...ts/normalCases/amd/define-wrapper/lib2.js → ...ts/configCases/amd/define-wrapper/lib2.js b/...ts/normalCases/amd/define-wrapper/lib2.js → ...ts/configCases/amd/define-wrapper/lib2.js
diff --git a/packages/rspack-test-tools/tests/configCases/amd/define-wrapper/rspack.config.js b/packages/rspack-test-tools/tests/configCases/amd/define-wrapper/rspack.config.js
@@ -0,0 +1,4 @@
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	amd: {},
+};
diff --git a/...ses/amd/real-amd-libs/define-in-params.js → ...ses/amd/real-amd-libs/define-in-params.js b/...ses/amd/real-amd-libs/define-in-params.js → ...ses/amd/real-amd-libs/define-in-params.js
diff --git a/...ts/normalCases/amd/real-amd-libs/index.js → ...ts/configCases/amd/real-amd-libs/index.js b/...ts/normalCases/amd/real-amd-libs/index.js → ...ts/configCases/amd/real-amd-libs/index.js
diff --git a/...ormalCases/amd/real-amd-libs/jquery-ui.js → ...onfigCases/amd/real-amd-libs/jquery-ui.js b/...ormalCases/amd/real-amd-libs/jquery-ui.js → ...onfigCases/amd/real-amd-libs/jquery-ui.js
diff --git a/...s/normalCases/amd/real-amd-libs/jquery.js → ...s/configCases/amd/real-amd-libs/jquery.js b/...s/normalCases/amd/real-amd-libs/jquery.js → ...s/configCases/amd/real-amd-libs/jquery.js
diff --git a/...lCases/amd/real-amd-libs/json-logic-js.js → ...gCases/amd/real-amd-libs/json-logic-js.js b/...lCases/amd/real-amd-libs/json-logic-js.js → ...gCases/amd/real-amd-libs/json-logic-js.js
diff --git a/packages/rspack-test-tools/tests/configCases/amd/real-amd-libs/rspack.config.js b/packages/rspack-test-tools/tests/configCases/amd/real-amd-libs/rspack.config.js
@@ -0,0 +1,4 @@
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	amd: {},
+};
diff --git a/...s/amd/real-amd-libs/webpack-umd-output.js → ...s/amd/real-amd-libs/webpack-umd-output.js b/...s/amd/real-amd-libs/webpack-umd-output.js → ...s/amd/real-amd-libs/webpack-umd-output.js
diff --git a/...alCases/amd/require-error-callback/add.js → ...igCases/amd/require-error-callback/add.js b/...alCases/amd/require-error-callback/add.js → ...igCases/amd/require-error-callback/add.js
diff --git a/...Cases/amd/require-error-callback/index.js → ...Cases/amd/require-error-callback/index.js b/...Cases/amd/require-error-callback/index.js → ...Cases/amd/require-error-callback/index.js
diff --git a/packages/rspack-test-tools/tests/configCases/amd/require-error-callback/rspack.config.js b/packages/rspack-test-tools/tests/configCases/amd/require-error-callback/rspack.config.js
@@ -0,0 +1,4 @@
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	amd: {},
+};
diff --git a/...alCases/amd/require-local-module/index.js → ...igCases/amd/require-local-module/index.js b/...alCases/amd/require-local-module/index.js → ...igCases/amd/require-local-module/index.js
diff --git a/packages/rspack-test-tools/tests/configCases/amd/require-local-module/rspack.config.js b/packages/rspack-test-tools/tests/configCases/amd/require-local-module/rspack.config.js
@@ -0,0 +1,4 @@
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	amd: {},
+};
diff --git a/...malCases/amd/require-unsupported/index.js → ...figCases/amd/require-unsupported/index.js b/...malCases/amd/require-unsupported/index.js → ...figCases/amd/require-unsupported/index.js
diff --git a/packages/rspack-test-tools/tests/configCases/amd/require-unsupported/rspack.config.js b/packages/rspack-test-tools/tests/configCases/amd/require-unsupported/rspack.config.js
@@ -0,0 +1,4 @@
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	amd: {},
+};
diff --git a/...Cases/amd/require-unsupported/warnings.js → ...Cases/amd/require-unsupported/warnings.js b/...Cases/amd/require-unsupported/warnings.js → ...Cases/amd/require-unsupported/warnings.js
diff --git a/...ts/normalCases/amd/require-wrapper/add.js → ...ts/configCases/amd/require-wrapper/add.js b/...ts/normalCases/amd/require-wrapper/add.js → ...ts/configCases/amd/require-wrapper/add.js
diff --git a/...malCases/amd/require-wrapper/constants.js → ...figCases/amd/require-wrapper/constants.js b/...malCases/amd/require-wrapper/constants.js → ...figCases/amd/require-wrapper/constants.js
diff --git a/.../normalCases/amd/require-wrapper/hello.js → .../configCases/amd/require-wrapper/hello.js b/.../normalCases/amd/require-wrapper/hello.js → .../configCases/amd/require-wrapper/hello.js
diff --git a/.../normalCases/amd/require-wrapper/index.js → .../configCases/amd/require-wrapper/index.js b/.../normalCases/amd/require-wrapper/index.js → .../configCases/amd/require-wrapper/index.js
diff --git a/packages/rspack-test-tools/tests/configCases/amd/require-wrapper/rspack.config.js b/packages/rspack-test-tools/tests/configCases/amd/require-wrapper/rspack.config.js
@@ -0,0 +1,4 @@
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	amd: {},
+};
diff --git a/...ools/tests/normalCases/amd/require/add.js → ...ools/tests/configCases/amd/require/add.js b/...ools/tests/normalCases/amd/require/add.js → ...ools/tests/configCases/amd/require/add.js
diff --git a/...ools/tests/normalCases/amd/require/dep.js → ...ools/tests/configCases/amd/require/dep.js b/...ools/tests/normalCases/amd/require/dep.js → ...ools/tests/configCases/amd/require/dep.js
diff --git a/packages/rspack-test-tools/tests/configCases/amd/require/fn.js b/packages/rspack-test-tools/tests/configCases/amd/require/fn.js
@@ -0,0 +1,4 @@
+module.exports.value = undefined;
+module.exports = (newValue) => {
+  module.exports.value = newValue;
+}
diff --git a/...ls/tests/normalCases/amd/require/index.js → ...ls/tests/configCases/amd/require/index.js b/...ls/tests/normalCases/amd/require/index.js → ...ls/tests/configCases/amd/require/index.js
@@ -4,7 +4,7 @@ it("require([...]) should work well", async function () {
 
 	await p;
 
-	expect(require('./fn')).toHaveBeenCalledWith(123);
+	expect(require('./fn').value).toBe(123);
 });
 
 it("require([...], function () {}) should work well", function (done) {

diff --git a/packages/rspack-test-tools/tests/configCases/amd/require/rspack.config.js b/packages/rspack-test-tools/tests/configCases/amd/require/rspack.config.js
@@ -0,0 +1,4 @@
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	amd: {},
+};
diff --git a/packages/rspack-test-tools/tests/normalCases/amd/require/fn.js b/packages/rspack-test-tools/tests/normalCases/amd/require/fn.js
diff --git a/packages/rspack/src/config/adapter.ts b/packages/rspack/src/config/adapter.ts
@@ -99,7 +99,7 @@ export const getRawOptions = (
 		experiments,
 		node: getRawNode(options.node),
 		profile: options.profile!,
-		amd: options.amd !== false ? JSON.stringify(options.amd || {}) : undefined,
+		amd: options.amd ? JSON.stringify(options.amd || {}) : undefined,
 		bail: options.bail!,
 		__references: {}
 	};

diff --git a/tests/webpack-test/ConfigTestCases.template.js b/tests/webpack-test/ConfigTestCases.template.js
@@ -91,6 +91,7 @@ const describeCases = config => {
 							}).not.toThrow();
 							optionsArr = [].concat(options);
 							optionsArr.forEach((options, idx) => {
+								if (options.amd === undefined) options.amd = {};
 								if (!options.context) options.context = testDirectory;
 								if (!options.mode) options.mode = "production";
 								if (!options.optimization) options.optimization = {};

diff --git a/tests/webpack-test/TestCases.template.js b/tests/webpack-test/TestCases.template.js
@@ -97,6 +97,7 @@ const describeCases = config => {
 							});
 							let options = {
 								...testConfig,
+								amd: {},
 								context: casesPath,
 								entry: "./" + category.name + "/" + testName + "/",
 								target: config.target || "async-node",

diff --git a/tests/webpack-test/__snapshots__/StatsTestCases.basictest.js.snap b/tests/webpack-test/__snapshots__/StatsTestCases.basictest.js.snap
@@ -574,61 +574,101 @@ Rspack x.x.x compiled successfully in X.23"
 
 exports[`StatsTestCases should print correct stats for limit-chunk-count-plugin 1`] = `
 "1 chunks:
-  asset bundle1.js 3.86 KiB [emitted] (name: main)
-  chunk (runtime: main) bundle1.js (main) 219 bytes (javascript) 1.84 KiB (runtime) <{909}> >{909}< [entry] [rendered]
+  asset bundle1.js 4.04 KiB [emitted] (name: main)
+  chunk (runtime: main) bundle1.js (main) 357 bytes (javascript) 1.84 KiB (runtime) <{909}> >{909}< [entry] [rendered]
     ./a.js 22 bytes [dependent] [built] [code generated]
-    ./b.js 22 bytes [dependent] [built] [code generated]
     ./c.js 30 bytes [dependent] [built] [code generated]
     ./d.js 22 bytes [dependent] [built] [code generated]
     ./e.js 22 bytes [dependent] [built] [code generated]
-    ./index.js 101 bytes [built] [code generated]
-  1 chunks (Rspack x.x.x) compiled successfully in X.23
+    ./index.js 101 bytes [built] [code generated] [1 warning]
+    Xdir/limit-chunk-count-plugin|sync 160 bytes [dependent] [built] [code generated]
+
+  WARNING in ./index.js
+    ⚠ Critical dependency: the request of a dependency is an expression
+     ╭─[2:8]
+   1 │ require.ensure([\\"./a\\"], function() {});
+   2 │ require([\\"./b\\"]);
+     ·         ────────
+   3 │ import(/* webpackChunkName: \\"c\\" */ \\"./c\\");
+     ╰────
+
+  1 chunks (Rspack x.x.x) compiled with 1 warning in X.23
 
 2 chunks:
-  asset bundle2.js 10.3 KiB [emitted] (name: main)
-  asset 76.bundle2.js 599 bytes [emitted] (name: c)
-  chunk (runtime: main) 76.bundle2.js (c) 118 bytes <{76}> <{909}> >{76}< [rendered]
+  asset bundle2.js 10.6 KiB [emitted] (name: main)
+  asset 76.bundle2.js 545 bytes [emitted] (name: c)
+  chunk (runtime: main) 76.bundle2.js (c) 96 bytes <{76}> <{909}> >{76}< [rendered]
     dependent modules 44 bytes [dependent]
       ./d.js 22 bytes [dependent] [built] [code generated]
       ./e.js 22 bytes [dependent] [built] [code generated]
     ./a.js 22 bytes [built] [code generated]
-    ./b.js 22 bytes [built] [code generated]
     ./c.js 30 bytes [built] [code generated]
-  chunk (runtime: main) bundle2.js (main) 101 bytes (javascript) 8.46 KiB (runtime) >{76}< [entry] [rendered]
-    ./index.js 101 bytes [built] [code generated]
-  2 chunks (Rspack x.x.x) compiled successfully in X.23
+  chunk (runtime: main) bundle2.js (main) 261 bytes (javascript) 8.46 KiB (runtime) >{76}< [entry] [rendered]
+    ./index.js 101 bytes [built] [code generated] [1 warning]
+    Xdir/limit-chunk-count-plugin|sync 160 bytes [dependent] [built] [code generated]
+
+  WARNING in ./index.js
+    ⚠ Critical dependency: the request of a dependency is an expression
+     ╭─[2:8]
+   1 │ require.ensure([\\"./a\\"], function() {});
+   2 │ require([\\"./b\\"]);
+     ·         ────────
+   3 │ import(/* webpackChunkName: \\"c\\" */ \\"./c\\");
+     ╰────
+
+  2 chunks (Rspack x.x.x) compiled with 1 warning in X.23
 
 3 chunks:
-  asset bundle3.js 10.3 KiB [emitted] (name: main)
+  asset bundle3.js 10.6 KiB [emitted] (name: main)
   asset 76.bundle3.js 385 bytes [emitted] (name: c)
-  asset 656.bundle3.js 290 bytes [emitted]
-  chunk (runtime: main) 656.bundle3.js 88 bytes <{76}> <{909}> [rendered]
+  asset 588.bundle3.js 236 bytes [emitted]
+  chunk (runtime: main) 588.bundle3.js 66 bytes <{76}> <{909}> [rendered]
     ./a.js 22 bytes [built] [code generated]
-    ./b.js 22 bytes [built] [code generated]
     ./d.js 22 bytes [built] [code generated]
     ./e.js 22 bytes [built] [code generated]
-  chunk (runtime: main) 76.bundle3.js (c) 30 bytes <{909}> >{656}< [rendered]
+  chunk (runtime: main) 76.bundle3.js (c) 30 bytes <{909}> >{588}< [rendered]
     ./c.js 30 bytes [built] [code generated]
-  chunk (runtime: main) bundle3.js (main) 101 bytes (javascript) 8.46 KiB (runtime) >{656}< >{76}< [entry] [rendered]
-    ./index.js 101 bytes [built] [code generated]
-  3 chunks (Rspack x.x.x) compiled successfully in X.23
+  chunk (runtime: main) bundle3.js (main) 261 bytes (javascript) 8.46 KiB (runtime) >{588}< >{76}< [entry] [rendered]
+    ./index.js 101 bytes [built] [code generated] [1 warning]
+    Xdir/limit-chunk-count-plugin|sync 160 bytes [dependent] [built] [code generated]
+
+  WARNING in ./index.js
+    ⚠ Critical dependency: the request of a dependency is an expression
+     ╭─[2:8]
+   1 │ require.ensure([\\"./a\\"], function() {});
+   2 │ require([\\"./b\\"]);
+     ·         ────────
+   3 │ import(/* webpackChunkName: \\"c\\" */ \\"./c\\");
+     ╰────
+
+  3 chunks (Rspack x.x.x) compiled with 1 warning in X.23
 
 4 chunks:
-  asset bundle4.js 10.3 KiB [emitted] (name: main)
+  asset bundle4.js 10.6 KiB [emitted] (name: main)
   asset 76.bundle4.js 385 bytes [emitted] (name: c)
-  asset 537.bundle4.js 236 bytes [emitted]
-  asset 697.bundle4.js 128 bytes [emitted]
-  chunk (runtime: main) 537.bundle4.js 66 bytes <{76}> <{909}> [rendered]
+  asset 345.bundle4.js 182 bytes [emitted]
+  asset 272.bundle4.js 128 bytes [emitted]
+  chunk (runtime: main) 272.bundle4.js 22 bytes <{909}> [rendered]
     ./a.js 22 bytes [built] [code generated]
-    ./b.js 22 bytes [built] [code generated]
+  chunk (runtime: main) 345.bundle4.js 44 bytes <{76}> [rendered]
     ./d.js 22 bytes [built] [code generated]
-  chunk (runtime: main) 697.bundle4.js 22 bytes <{76}> [rendered]
     ./e.js 22 bytes [built] [code generated]
-  chunk (runtime: main) 76.bundle4.js (c) 30 bytes <{909}> >{537}< >{697}< [rendered]
+  chunk (runtime: main) 76.bundle4.js (c) 30 bytes <{909}> >{345}< [rendered]
     ./c.js 30 bytes [built] [code generated]
-  chunk (runtime: main) bundle4.js (main) 101 bytes (javascript) 8.46 KiB (runtime) >{537}< >{76}< [entry] [rendered]
-    ./index.js 101 bytes [built] [code generated]
-  4 chunks (Rspack x.x.x) compiled successfully in X.23"
+  chunk (runtime: main) bundle4.js (main) 261 bytes (javascript) 8.46 KiB (runtime) >{272}< >{76}< [entry] [rendered]
+    ./index.js 101 bytes [built] [code generated] [1 warning]
+    Xdir/limit-chunk-count-plugin|sync 160 bytes [dependent] [built] [code generated]
+
+  WARNING in ./index.js
+    ⚠ Critical dependency: the request of a dependency is an expression
+     ╭─[2:8]
+   1 │ require.ensure([\\"./a\\"], function() {});
+   2 │ require([\\"./b\\"]);
+     ·         ────────
+   3 │ import(/* webpackChunkName: \\"c\\" */ \\"./c\\");
+     ╰────
+
+  4 chunks (Rspack x.x.x) compiled with 1 warning in X.23"
 `;
 
 exports[`StatsTestCases should print correct stats for logging-debug 1`] = `

diff --git a/tests/webpack-test/cases/amd/define-needs-module/test.filter.js b/tests/webpack-test/cases/amd/define-needs-module/test.filter.js
diff --git a/tests/webpack-test/cases/amd/namedModules/test.filter.js b/tests/webpack-test/cases/amd/namedModules/test.filter.js
diff --git a/tests/webpack-test/cases/amd/namedModulesConstArrayDep/test.filter.js b/tests/webpack-test/cases/amd/namedModulesConstArrayDep/test.filter.js
@@ -1,4 +1,4 @@
 
-module.exports = () => {return "https://github.com/web-infra-dev/rspack/issues/4313"}
+module.exports = () => {return "compile time eval split"}
 
 
diff --git a/tests/webpack-test/cases/cjs-tree-shaking/bailouts/index.js b/tests/webpack-test/cases/cjs-tree-shaking/bailouts/index.js
@@ -50,7 +50,7 @@ it("should be able to do stuff with the module object", () => {
 	expect(require("./accessing-module?1").def).toBe("def");
 });
 
-// it("should be able to use AMD to define exports", () => {
-// 	expect(require("./using-amd?2").abc).toBe("abc");
-// 	expect(require("./using-amd?1").def).toBe("def");
-// });
+it("should be able to use AMD to define exports", () => {
+	expect(require("./using-amd?2").abc).toBe("abc");
+	expect(require("./using-amd?1").def).toBe("def");
+});
diff --git a/tests/webpack-test/cases/cjs-tree-shaking/bailouts/test.filter.js b/tests/webpack-test/cases/cjs-tree-shaking/bailouts/test.filter.js
diff --git a/tests/webpack-test/cases/parsing/amd-rename/test.filter.js b/tests/webpack-test/cases/parsing/amd-rename/test.filter.js
diff --git a/tests/webpack-test/cases/parsing/complex-require/test.filter.js b/tests/webpack-test/cases/parsing/complex-require/test.filter.js
@@ -11,7 +11,7 @@ module.exports = function (config) {
 module.exports = () => {
 	return [
 		FilteredStatus.PARTIAL_PASS,
-		"https://github.com/web-infra-dev/rspack/issues/4313",
+		"amd require context",
 		"require(String.raw``)"
 	];
 };
diff --git a/tests/webpack-test/cases/parsing/declared-api/test.filter.js b/tests/webpack-test/cases/parsing/declared-api/test.filter.js
diff --git a/tests/webpack-test/cases/parsing/extract-amd.nominimize/test.filter.js b/tests/webpack-test/cases/parsing/extract-amd.nominimize/test.filter.js
@@ -7,6 +7,6 @@ module.exports = function (config) {
 };
 
 */
-module.exports = () => {return "https://github.com/web-infra-dev/rspack/issues/4313"}
+module.exports = () => {return "amd require context"}
 
 
diff --git a/tests/webpack-test/cases/parsing/extract-amd/test.filter.js b/tests/webpack-test/cases/parsing/extract-amd/test.filter.js
@@ -1,4 +1,4 @@
 
-module.exports = () => {return "https://github.com/web-infra-dev/rspack/issues/4313"}
+module.exports = () => {return "amd require context"}
 
 
diff --git a/tests/webpack-test/cases/parsing/harmony-injecting-order/test.filter.js b/tests/webpack-test/cases/parsing/harmony-injecting-order/test.filter.js
@@ -1,4 +1,3 @@
-
-module.exports = () => {return "https://github.com/web-infra-dev/rspack/issues/4313"}
+module.exports = () => {return "__webpack_amd_options__ module variable"}
 
 
diff --git a/tests/webpack-test/cases/parsing/issue-2084/test.filter.js b/tests/webpack-test/cases/parsing/issue-2084/test.filter.js
diff --git a/tests/webpack-test/cases/parsing/issue-2641/index.js b/tests/webpack-test/cases/parsing/issue-2641/index.js
@@ -19,17 +19,17 @@ it("should call error callback on missing module", function(done) {
 	});
 });
 
-it("should call error callback on missing module in context", function(done) {
-	(function(module) {
-		require(['./' + module], function(file){}, function(error) {
-			try {
-				expect(error).toBeInstanceOf(Error);
-				expect(error.message).toBe("Cannot find module './missingModule'");
-				done();
-			} catch(e) { done(e); }
-		});
-	})('missingModule');
-});
+// it("should call error callback on missing module in context", function(done) {
+// 	(function(module) {
+// 		require(['./' + module], function(file){}, function(error) {
+// 			try {
+// 				expect(error).toBeInstanceOf(Error);
+// 				expect(error.message).toBe("Cannot find module './missingModule'");
+// 				done();
+// 			} catch(e) { done(e); }
+// 		});
+// 	})('missingModule');
+// });
 
 it("should call error callback on exception thrown in loading module", function(done) {
 	require(['./throwing'], function(){}, function(error) {

diff --git a/tests/webpack-test/cases/parsing/issue-2641/test.filter.js b/tests/webpack-test/cases/parsing/issue-2641/test.filter.js
@@ -1,4 +1,4 @@
 
-module.exports = () => {return "https://github.com/web-infra-dev/rspack/issues/4313"}
+module.exports = () => {return "error callback on missing module in context"}
Original file line number	Diff line number	Diff line change
		@@ -1,4 +1,4 @@

		module.exports = () => {return "https://github.com/web-infra-dev/rspack/issues/4313"}
		module.exports = () => {return "compile time eval split"}
-Original file line number
+Diff line change
@@ Expand Up / @@ -7,6 +7,6 @@ module.exports = function (config) { @@
     };
     */
-    module.exports = () => {return "https://github.com/web-infra-dev/rspack/issues/4313"}
+    module.exports = () => {return "amd require context"}
Original file line number	Diff line number	Diff line change
		@@ -1,4 +1,4 @@

		module.exports = () => {return "https://github.com/web-infra-dev/rspack/issues/4313"}
		module.exports = () => {return "amd require context"}
Original file line number	Diff line number	Diff line change
		@@ -1,4 +1,3 @@

		module.exports = () => {return "https://github.com/web-infra-dev/rspack/issues/4313"}
		module.exports = () => {return "__webpack_amd_options__ module variable"}
Original file line number	Diff line number	Diff line change
		@@ -1,4 +1,4 @@

		module.exports = () => {return "https://github.com/web-infra-dev/rspack/issues/4313"}
		module.exports = () => {return "error callback on missing module in context"}
Name	Base (2025-01-21 c06787b)	Current	Change
10000_big_production-mode_disable-minimize + exec	36.7 s ± 515 ms	38.9 s ± 1.12 s	+5.90 %
10000_development-mode + exec	1.86 s ± 52 ms	1.85 s ± 96 ms	-0.77 %
10000_development-mode_hmr + exec	681 ms ± 9.8 ms	687 ms ± 27 ms	+0.86 %
10000_production-mode + exec	2.45 s ± 138 ms	2.38 s ± 57 ms	-2.62 %
10000_production-mode_persistent-cold + exec	2.61 s ± 155 ms	2.56 s ± 83 ms	-2.03 %
10000_production-mode_persistent-hot + exec	1.77 s ± 116 ms	1.77 s ± 81 ms	+0.06 %
arco-pro_development-mode + exec	1.76 s ± 98 ms	1.8 s ± 164 ms	+2.16 %
arco-pro_development-mode_hmr + exec	388 ms ± 2.3 ms	387 ms ± 1.2 ms	-0.10 %
arco-pro_production-mode + exec	3.64 s ± 257 ms	3.74 s ± 313 ms	+2.82 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec	3.75 s ± 314 ms	3.7 s ± 106 ms	-1.31 %
arco-pro_production-mode_persistent-cold + exec	3.8 s ± 165 ms	3.81 s ± 171 ms	+0.37 %
arco-pro_production-mode_persistent-hot + exec	2.34 s ± 79 ms	2.57 s ± 94 ms	+9.99 %
arco-pro_production-mode_traverse-chunk-modules + exec	3.67 s ± 99 ms	3.64 s ± 57 ms	-0.62 %
large-dyn-imports_development-mode + exec	2.11 s ± 29 ms	2.1 s ± 73 ms	-0.30 %
large-dyn-imports_production-mode + exec	2.16 s ± 40 ms	2.15 s ± 25 ms	-0.33 %
threejs_development-mode_10x + exec	1.53 s ± 22 ms	1.54 s ± 27 ms	+0.85 %
threejs_development-mode_10x_hmr + exec	788 ms ± 39 ms	789 ms ± 5.4 ms	+0.06 %
threejs_production-mode_10x + exec	5.25 s ± 61 ms	5.47 s ± 252 ms	+4.17 %
threejs_production-mode_10x_persistent-cold + exec	5.35 s ± 65 ms	5.58 s ± 280 ms	+4.29 %
threejs_production-mode_10x_persistent-hot + exec	4.5 s ± 44 ms	4.81 s ± 310 ms	+6.84 %
10000_big_production-mode_disable-minimize + rss memory	8680 MiB ± 34.2 MiB	8717 MiB ± 54 MiB	+0.42 %
10000_development-mode + rss memory	656 MiB ± 19.6 MiB	662 MiB ± 28.1 MiB	+0.92 %
10000_development-mode_hmr + rss memory	1264 MiB ± 163 MiB	1281 MiB ± 253 MiB	+1.34 %
10000_production-mode + rss memory	639 MiB ± 31 MiB	641 MiB ± 15.7 MiB	+0.26 %
10000_production-mode_persistent-cold + rss memory	744 MiB ± 15.6 MiB	744 MiB ± 23.5 MiB	-0.04 %
10000_production-mode_persistent-hot + rss memory	723 MiB ± 37.7 MiB	730 MiB ± 12.4 MiB	+0.98 %
arco-pro_development-mode + rss memory	553 MiB ± 38.1 MiB	559 MiB ± 31.1 MiB	+1.06 %
arco-pro_development-mode_hmr + rss memory	631 MiB ± 36 MiB	671 MiB ± 21.5 MiB	+6.29 %
arco-pro_production-mode + rss memory	738 MiB ± 66.3 MiB	712 MiB ± 25.7 MiB	-3.49 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory	730 MiB ± 23.1 MiB	718 MiB ± 24.6 MiB	-1.62 %
arco-pro_production-mode_persistent-cold + rss memory	844 MiB ± 36.6 MiB	831 MiB ± 47 MiB	-1.48 %
arco-pro_production-mode_persistent-hot + rss memory	695 MiB ± 19.9 MiB	701 MiB ± 14.7 MiB	+0.86 %
arco-pro_production-mode_traverse-chunk-modules + rss memory	727 MiB ± 32.5 MiB	725 MiB ± 44.3 MiB	-0.26 %
large-dyn-imports_development-mode + rss memory	642 MiB ± 4.5 MiB	640 MiB ± 8.09 MiB	-0.23 %
large-dyn-imports_production-mode + rss memory	523 MiB ± 4.79 MiB	523 MiB ± 3.46 MiB	-0.03 %
threejs_development-mode_10x + rss memory	551 MiB ± 32.9 MiB	540 MiB ± 21.9 MiB	-1.85 %
threejs_development-mode_10x_hmr + rss memory	1145 MiB ± 125 MiB	1130 MiB ± 90.2 MiB	-1.29 %
threejs_production-mode_10x + rss memory	865 MiB ± 36.9 MiB	822 MiB ± 28.7 MiB	-5.02 %
threejs_production-mode_10x_persistent-cold + rss memory	968 MiB ± 136 MiB	939 MiB ± 66.8 MiB	-2.95 %
threejs_production-mode_10x_persistent-hot + rss memory	870 MiB ± 25.8 MiB	854 MiB ± 28.1 MiB	-1.80 %
suite	result
modernjs	❌ failure
rspress	✅ success
rslib	❌ failure
rsbuild	✅ success
rsdoctor	✅ success
examples	✅ success
devserver	✅ success
nuxt	✅ success