Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should copy publicDir to the environment distDir when multiple environments #4220

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix: should copy publicDir to the environment distDir when multiple environments #4220

merged 1 commit into from
Dec 20, 2024

Conversation

9aoy
Copy link
Contributor

@9aoy 9aoy commented Dec 19, 2024 •
edited
Loading

Summary

should copy publicDir to the environment distDir when multiple environments.

Related Links

web-infra-dev/rslib#583

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Dec 19, 2024 •
edited
Loading

✅ Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 25a3305
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67642253553f410008a3e822
😎 Deploy Preview https://deploy-preview-4220--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 55 (🔴 down 29 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@9aoy 9aoy merged commit 2b5570e into main Dec 20, 2024
10 checks passed
@9aoy 9aoy deleted the fix/copy-public-dir branch December 20, 2024 03:47
@9aoy 9aoy mentioned this pull request Dec 20, 2024
Closed
@chenjiahan chenjiahan mentioned this pull request Dec 21, 2024
Merged
@coratgerl coratgerl mentioned this pull request Dec 21, 2024
Closed
chenjiahan added a commit that referenced this pull request Dec 22, 2024
@chenjiahan
Revert "fix: should copy publicDir to the environment distDir when mu…
8abff8e 
…ltiple environments (#4220)"

This reverts commit 2b5570e.
@chenjiahan chenjiahan mentioned this pull request Dec 22, 2024
Merged
2 tasks
chenjiahan added a commit that referenced this pull request Dec 22, 2024
@chenjiahan
Revert "fix: should copy publicDir to the environment distDir when mu…
9863b72 
…ltiple environments (#4220)" (#4240)
This was referenced Dec 22, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@9aoy