-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-assets-retry): support output.assetPrefix
with absolute url
#4129
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
output.assetPrefix
with absolute url
// this function is same with async chunk retry | ||
function getUrlRetryQuery( | ||
existRetryTimes: number, | ||
originalQuery: string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this originalQuery
param the same as const originalQuery
in L247?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, these two functions are exactly the same now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the originalQuery
param seems to be unnecessary in this file
Summary
let async-retry url calculating aligned with initial-retry
Before
only support
if you uses below
the retry contexts:
after