Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): remove dirname shims #3984

Merged
merged 5 commits into from
Nov 21, 2024
Merged

chore(build): remove dirname shims #3984

merged 5 commits into from
Nov 21, 2024

Conversation

chenjiahan
Copy link
Member

Summary

Remove __dirname and __filename shims of Rslib.

Related Links

blocked by web-infra-dev/rslib#425

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit e7c846e
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/673f03951b55570008f3cc77
😎 Deploy Preview https://deploy-preview-3984--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 73 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 9002838 into main Nov 21, 2024
9 checks passed
@chenjiahan chenjiahan deleted the dirname_shims_1115 branch November 21, 2024 12:20
@9aoy 9aoy mentioned this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant